Refactoring of DockerClientConfig to better match with docker CLI...#444
Refactoring of DockerClientConfig to better match with docker CLI...#444marcuslinke wants to merge 5 commits intomasterfrom
Conversation
configuration options
There was a problem hiding this comment.
what is the idea of adding it here?
There was a problem hiding this comment.
Passing a custom SSLContext to the DockerClientConfig could logically collide with the DOCKER_TLS_VERIFY/dockerTlsVerify() option in the sense of consistency. Additionally I want to free DockerClientConfig from non-default/special configuration options so I moved it to the DockerCmdExecFactory. Makes sense?
There was a problem hiding this comment.
Seems i totally confused with all this classes... Feel free to merge.
|
@marcuslinke imho it makes sense firstly made refactoring of all |
There was a problem hiding this comment.
&& isFile() afair more exact check
|
Closed in favor of rebased version: #447 |
2 participants
...configuration options.
This PR addresses issue #331. It renames all the config options/keys of docker-java to match better with the docker CLI environment options.