Merged
Conversation
Member
|
You can force push to existed branch + previous PR was mergeable. |
Closed
Member
There was a problem hiding this comment.
Collections.notEmpty() or something from guava that already do null check?
Member
|
You are merging faster than i'm reviewing. |
Contributor
Author
|
@KostyaSha Sorry, I thought you reviewed original PR already. |
Member
|
But new commits periodically appears new :) |
Member
|
Note, for any null/empty/string length try search for helpers in guava/commons/collections. or But null check from 1.8 doesn't catched by findbugs yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR eleminates the use of the generic
Filtersobject in the command APIs.