Skip to content

Refactoring of filters#423

Closed
marcuslinke wants to merge 12 commits intomasterfrom
refact-filters
Closed

Refactoring of filters#423
marcuslinke wants to merge 12 commits intomasterfrom
refact-filters

Conversation

@marcuslinke
Copy link
Copy Markdown
Contributor

This PR eleminates the use of the generic Filters object in the command APIs. Instead there are now seperate methods for each command specific filter.

ericfjosne and others added 10 commits August 17, 2015 16:03
dev-feat-20150817-AddedFilterForListImages

Conflicts:
	src/main/java/com/github/dockerjava/core/command/ListImagesCmdImpl.java
	src/main/java/com/github/dockerjava/jaxrs/ListImagesCmdExec.java
https://github.com/ericfjosne/docker-java into
ericfjosne-dev-feat-20150817-AddedFilterForListImages

Conflicts:
	src/main/java/com/github/dockerjava/api/model/PullResponseItem.java
@marcuslinke
Copy link
Copy Markdown
Contributor Author

After merging https://github.com/docker-java/docker-java/tree/issue-356 into master refactoring of filters of list networks command is needed also.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo?

@marcuslinke
Copy link
Copy Markdown
Contributor Author

Closing this in favor of merged PR #426

@KostyaSha
Copy link
Copy Markdown
Member

No need to merge master, you can just git rebase master branch locally, then review and force push back.

@KostyaSha KostyaSha added this to the 3.0.0 milestone Jan 18, 2016
@KostyaSha
Copy link
Copy Markdown
Member

Plus it will keep authors.

@marcuslinke marcuslinke deleted the refact-filters branch January 20, 2016 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants