Skip to content

Support for volume API#408

Closed
marcuslinke wants to merge 3 commits intomasterfrom
issue-329
Closed

Support for volume API#408
marcuslinke wants to merge 3 commits intomasterfrom
issue-329

Conversation

@marcuslinke
Copy link
Copy Markdown
Contributor

@marcuslinke marcuslinke commented Dec 18, 2015

fixes issue #329

KostyaSha
KostyaSha reviewed Dec 18, 2015
View reviewed changes
src/main/java/com/github/dockerjava/api/command/CreateVolumeCmd.java Outdated
Copy link
Copy Markdown
Member

@KostyaSha KostyaSha Dec 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line

@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Dec 18, 2015

@marcuslinke have you successfully run build locally with static analysing profile enabled? :)

@marcuslinke
Copy link
Copy Markdown
Contributor Author

marcuslinke commented Dec 18, 2015

@KostyaSha Sorry, what do you mean. Doesn't a simple mvn clean install should be sufficient?

@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Dec 18, 2015

@marcuslinke install will pollute your local repo :) mvn -Pdocker-java-analysis package or just mvn package (because profile is enabled by default) should be enough if you didn't disable profile in your ide. But probably checkstyle doesn't contain new line check. In general having new lines in the end of file is good tone (starting from time when NL was expected as end of stream/resource) and excludes red icon.

@marcuslinke
Copy link
Copy Markdown
Contributor Author

marcuslinke commented Dec 18, 2015

OK. newlines fixed now.

@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Dec 18, 2015

@marcuslinke could you merge #409 and rebase this PR? :)

@KostyaSha KostyaSha added this to the 3.0.0 milestone Dec 18, 2015
KostyaSha
KostyaSha reviewed Dec 18, 2015
View reviewed changes
src/main/java/com/github/dockerjava/api/command/CreateVolumeCmd.java
Copy link
Copy Markdown
Member

@KostyaSha KostyaSha Dec 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add javadoc when apparead? 1.21?

Copy link
Copy Markdown
Member

@KostyaSha KostyaSha Dec 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do myself later.

@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Dec 18, 2015

Is travis building merged state? let's check.

@KostyaSha KostyaSha closed this Dec 18, 2015
@KostyaSha KostyaSha reopened this Dec 18, 2015
@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Dec 18, 2015

Sorry, merge conflict. Hoped that it wouldn't.

KostyaSha added a commit that referenced this pull request Dec 19, 2015
@KostyaSha
Merge pull request #408
899f7ba
@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Dec 19, 2015

Added NL in missed file, fixuped two commits in one, merged manually to master.
This PR is really merged into master via 899f7ba .

@KostyaSha KostyaSha closed this Dec 19, 2015
@KostyaSha KostyaSha deleted the issue-329 branch December 23, 2015 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@marcuslinke marcuslinke

Labels

None yet

Projects

None yet

Milestone

3.0.0-RC1-RC3

Development

Successfully merging this pull request may close these issues.

2 participants

@marcuslinke @KostyaSha