Use BufferedInputStream to read from a tar file#402
Closed
mishail wants to merge 1 commit intodocker-java:2.xfrom
Closed
Use BufferedInputStream to read from a tar file#402mishail wants to merge 1 commit intodocker-java:2.xfrom
mishail wants to merge 1 commit intodocker-java:2.xfrom
Conversation
Contributor
|
Already fixed in master via #359 |
Contributor
|
Cherry-picked 1584e0d into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During my testing I've found that building an image with a fairly big context took a lot of time (several minutes) with docker-java. On the other hand,
dockerCLI was able to upload the very same context with the very same Dockerfile in 10-20 seconds.After some profiling I've found out that we spent most time trying to read from a context's tar file, and it turned out we didn't use
BufferedInputStreamaroundFileInputStream.Without the fix it took ~5 min to upload a ~153Mb context:
And with the fix it takes ~20 sec: