Skip to content

Make ProgressDetails attributes public #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcuslinke merged 2 commits into from
Dec 2, 2015
Merged

Make ProgressDetails attributes public #387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04de9fb
Make ProgressDetails attributes public
Dec 1, 2015
51e3983
Remove public from members as getters are public already
Dec 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/main/java/com/github/dockerjava/api/model/ResponseItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,18 @@ public static class ProgressDetail implements Serializable {
@JsonProperty("start")
long start;

public long getCurrent() {
Copy link
Copy Markdown
Member

@KostyaSha KostyaSha Dec 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this fields be null, should they be non primitive?

Copy link
Copy Markdown
Contributor Author

@marcuslinke marcuslinke Dec 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Targeted PR against 2.x branch, so leaving primitives. I will change to objects while merge into master.

Copy link
Copy Markdown
Member

@KostyaSha KostyaSha Dec 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking because have no idea how this responses are filled :)

return current;
}

public long getTotal() {
return total;
}

public long getStart() {
return start;
}

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE).toString();
Expand All @@ -124,6 +136,14 @@ public static class ErrorDetail implements Serializable {
@JsonProperty("message")
String message;

public int getCode() {
return code;
}

public String getMessage() {
return message;
}

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE).toString();
Expand Down