Remove special-case for one ":" from PullCommand#38
Remove special-case for one ":" from PullCommand#38marcuslinke merged 2 commits intodocker-java:masterfrom hmrm:master
Conversation
This special treatment breaks images with registries with a port specified, e.g. my-docker-registry:5000/my-namespace/my-image
|
I haven't managed to get the test suite working yet, so thing may break tests. I'll update once I've got that working. |
|
I'm seeing a bunch of failed tests even without this patch, here are the results from d6efb1b:
|
|
Hi @hmrm, what error messages you get. Here it is running without any error. |
|
Oh. Now i see that your comment contains error messages. Sorry, my fault. Will investigate... |
|
No worries, let me know if there's more information that would be useful! |
|
What docker server version do you use for tests? The tests passes with 1.1.0 here. With latest docker version 1.1.2 i also get some test errors but these are different from yours. I have committed the fixes, so please test again now against 1.1.2 if possible. |
|
Mystery solved, it looks like I'm running with an old version of docker: Server version: 0.11.1-dev I'll update and try again. |
|
Confirmed that this branch passes tests! |
Remove special-case for one ":" from PullCommand
|
@hmrm Glad that we could solve it. Thanks for your commit! |
|
@marcuslinke Thanks for the near-instant response time! |
This special treatment breaks images with registries with a port
specified, e.g. my-docker-registry:5000/my-namespace/my-image