Skip to content

Fix repository name validation errors#298

Merged
marcuslinke merged 2 commits intomasterfrom
issue-290
Aug 18, 2015
Merged

Fix repository name validation errors#298
marcuslinke merged 2 commits intomasterfrom
issue-290

Conversation

@marcuslinke
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe short RepoNameMaxLength?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable names are taken from docker sources. I would like to keep them.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😟

@KostyaSha
Copy link
Copy Markdown
Member

Do you have any generic Object that can parse, store and provide parts of this data in getters like getTag, getHost, getDigest?

 "proto://url:port/imagename:tag" (or digest) 

@marcuslinke
Copy link
Copy Markdown
Contributor Author

Sadly no. But as already said in another post all this name handling classes needs to be refactored. It's on my todo list, but I'm quite busy to fix bugs atm.

@KostyaSha
Copy link
Copy Markdown
Member

@marcuslinke no problems, all this partial classes periodically confuses TODO rework it is good idea

marcuslinke added a commit that referenced this pull request Aug 18, 2015
@marcuslinke marcuslinke merged commit 4c4a7ac into master Aug 18, 2015
@marcuslinke marcuslinke changed the title Fix issue #290 Fix repository name validation errors Aug 18, 2015
@KostyaSha
Copy link
Copy Markdown
Member

@marcuslinke it maybe good idea squashing such minor changes during merge to have better commit/blame history. I usually comparing docker-api docs, docker-java changes and docker client so it difficult sometimes jumping on styling commits

@KostyaSha
Copy link
Copy Markdown
Member

👍 for change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants