Skip to content

Added imageName filter for ListImagesCmd#297

Closed
ericfjosne wants to merge 7 commits intodocker-java:masterfrom
ericfjosne:dev-feat-20150817-AddedFilterForListImages
Closed

Added imageName filter for ListImagesCmd#297
ericfjosne wants to merge 7 commits intodocker-java:masterfrom
ericfjosne:dev-feat-20150817-AddedFilterForListImages

Conversation

@ericfjosne
Copy link
Copy Markdown

API allow for an image name filter. This was missing in the ListImagesCmd.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep new line before

@marcuslinke
Copy link
Copy Markdown
Contributor

@ericfjosne Thanks! A test case would be nice. Beside this there is an eclipse code formatting rule to format the sources automatically: https://github.com/docker-java/docker-java/blob/master/etc/code-style.epf

dev-feat-20150817-AddedFilterForListImages

Conflicts:
	src/main/java/com/github/dockerjava/core/command/ListImagesCmdImpl.java
	src/main/java/com/github/dockerjava/jaxrs/ListImagesCmdExec.java
@KostyaSha
Copy link
Copy Markdown
Member

Please rebase and fix formatting.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do toString from helpers (see some class), it was old idea to emulate command line.

@marcuslinke
Copy link
Copy Markdown
Contributor

Obsolete now. See #423.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants