Skip to content

remove withHostConfig() from create container command #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcuslinke merged 1 commit into from
Jul 16, 2015
Merged

remove withHostConfig() from create container command #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/main/java/com/github/dockerjava/api/command/CreateContainerCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
import com.github.dockerjava.api.model.Capability;
import com.github.dockerjava.api.model.Device;
import com.github.dockerjava.api.model.ExposedPort;
import com.github.dockerjava.api.model.HostConfig;
import com.github.dockerjava.api.model.Link;
import com.github.dockerjava.api.model.LxcConf;
import com.github.dockerjava.api.model.PortBinding;
import com.github.dockerjava.api.model.Ports;
import com.github.dockerjava.api.model.RestartPolicy;
import com.github.dockerjava.api.model.Ulimit;
import com.github.dockerjava.api.model.Volume;
import com.github.dockerjava.api.model.VolumesFrom;

Expand Down Expand Up @@ -77,8 +77,6 @@ public static interface Exec extends DockerCmdSyncExec<CreateContainerCmd, Creat

public String[] getExtraHosts();

public HostConfig getHostConfig();

public String getHostName();

public String getDomainName();
Expand Down Expand Up @@ -113,6 +111,8 @@ public static interface Exec extends DockerCmdSyncExec<CreateContainerCmd, Creat

public String getWorkingDir();

public Ulimit[] getUlimits();

public boolean isAttachStderr();

public boolean isAttachStdin();
Expand Down Expand Up @@ -207,8 +207,6 @@ public static interface Exec extends DockerCmdSyncExec<CreateContainerCmd, Creat
*/
public CreateContainerCmd withExtraHosts(String... extraHosts);

public CreateContainerCmd withHostConfig(HostConfig hostConfig);

public CreateContainerCmd withHostName(String hostName);

public CreateContainerCmd withDomainName(String domainName);
Expand Down Expand Up @@ -282,6 +280,12 @@ public static interface Exec extends DockerCmdSyncExec<CreateContainerCmd, Creat

public CreateContainerCmd withMacAddress(String macAddress);

public CreateContainerCmd withUlimits(Ulimit[] ulimits);

public CreateContainerCmd withReadonlyRootfs(boolean readonlyRootfs);

public CreateContainerCmd withContainerIDFile(String containerIDFile);

/**
* @return
*/
Expand Down
Loading