Passing result callbacks for async commands via commands exec() method#270
Merged
marcuslinke merged 2 commits intomasterfrom Jul 15, 2015
Merged
Passing result callbacks for async commands via commands exec() method#270marcuslinke merged 2 commits intomasterfrom
marcuslinke merged 2 commits intomasterfrom
Conversation
marcuslinke
changed the title
marcuslinke
changed the title
marcuslinke
added a commit
that referenced
this pull request
Jul 15, 2015
Passing result callbacks for async commands via commands exec() method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the async commands API (stats, events, log, attach, build, push, pull) so that result callbacks can be passed within the call to exec() method of a command.