Accept filters in list containers#262
Merged
marcuslinke merged 3 commits intodocker-java:masterfrom Jul 11, 2015
Merged
Conversation
Contributor
Author
|
The filters query param in Docker API is a pita, it is a json representation of the filters ( |
Contributor
There was a problem hiding this comment.
This specific test doesn't work in my local test env (docker api 1.18). The is no filtering when passing label filter without 'label' keyword.
Contributor
|
Seems the label filtering is somehow broken with docker 1.7.0/1.19 also. It finds containers that haven't a label at all. An appropriate log example: |
Contributor
Author
|
Yes, seems I misunderstood the docs. I have debugged the daemon logs and updated the implementation to work with |
Contributor
|
@carlossg Thanks for your contribution! |
calavera
pushed a commit
to calavera/docker
that referenced
this pull request
Jul 25, 2015
Based on the list containers with filters options it would seem that filtering containers with label `test=docker-java` could be done with `{"test":["docker-java"]}` which doesn't work
The options that work are `{"label":["test"]}` and `{"label":["test=docker-java"]}`
As seen in docker-java/docker-java#262
Signed-off-by: Carlos Sanchez <[email protected]>
tiborvass
pushed a commit
to tiborvass/docker
that referenced
this pull request
Jul 27, 2015
Based on the list containers with filters options it would seem that filtering containers with label `test=docker-java` could be done with `{"test":["docker-java"]}` which doesn't work
The options that work are `{"label":["test"]}` and `{"label":["test=docker-java"]}`
As seen in docker-java/docker-java#262
Signed-off-by: Carlos Sanchez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR on top of #260, to test with container labels