[WiP] Add filters option to events operation#261
Closed
carlossg wants to merge 30 commits intodocker-java:refact-streamingfrom
Closed
[WiP] Add filters option to events operation#261carlossg wants to merge 30 commits intodocker-java:refact-streamingfrom
carlossg wants to merge 30 commits intodocker-java:refact-streamingfrom
Conversation
Refactoring of streaming commands APIs (event, stats, log, attach)
Fix FrameReader after refactoring streaming commands
… carlossg-labels
… raychaser-swarm
…/docker-java into carlossg-list-containers-filters
Contributor
Author
|
This depends on #262, that defines the filters model. Once that's in, this one is easy to rework |
…/docker-java into carlossg-list-containers-filters
fix link to issue
KostyaSha-since Conflicts: src/main/java/com/github/dockerjava/core/command/CreateContainerCmdImpl.java
carlossg
force-pushed
the
refact-streaming-filters
branch
from
bc8cf93 to
87e9c19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplement #259 in refact-streaming branch and using a Filters object
The only thing pending is to properly encode the json parameters, left a TODO in EventsCmdExec