FrameReader has problems when buffer is only partially filled#251
Merged
alexec merged 2 commits intodocker-java:masterfrom Jun 18, 2015
Merged
FrameReader has problems when buffer is only partially filled#251alexec merged 2 commits intodocker-java:masterfrom
alexec merged 2 commits intodocker-java:masterfrom
Conversation
Contributor
|
ping @alexec |
Contributor
Author
|
Test failure (on CircleCI) appears unrelated |
Contributor
Author
|
@alexec I have patched some similar issues in the docker-maven-plugin and will open a PR there as well. For docker-maven-plugin this change needs to be applied, and also the changes in the separate PR |
Contributor
|
Ship it. |
alexec
added a commit
that referenced
this pull request
Jun 18, 2015
FrameReader has problems when buffer is only partially filled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some platforms (e.g. Windows), the Stream IO means the buffer is not completely filled on the first read. This patch modifies the behaviour to check if the buffer is partially filled for header or frame and allow the buffer to fill completely before processing it.