Fix parameter order in assertEquals#2066
Merged
eddumelendez merged 3 commits intodocker-java:masterfrom Feb 9, 2023
Merged
Conversation
Signed-off-by: Harald Albers <[email protected]>
Signed-off-by: Harald Albers <[email protected]>
Signed-off-by: Harald Albers <[email protected]>
eddumelendez
approved these changes
Feb 9, 2023
Member
|
Thanks for your contribution, @albers ! This is now merged in |
Contributor
Author
|
Thanks for the quick review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1923
Parameter order
Docker-Java used to implement its tests with TestNG until #909.
In TestNG,
assertEqualshas a different parameter order (actual, expected) compared to JUnit (expected, actual).Some old tests still use the old parameter ordering, some tests follow the JUnit semantics.
There are even test classes which mix both forms.
While this does not affect the validity of the tests, it confuses the reader and therefore should be cleaned up.
Housekeeping
Being at it, I did some basic housekeeping on the tests: I removed some unused imports and unneccessary throws declarations.