Skip to content

Add missing options to BuildCmd and set them to match Docker client. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcuslinke merged 2 commits into from
Jul 9, 2014
Merged

Add missing options to BuildCmd and set them to match Docker client. #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eb8342
Update BuildImgCmd options to match default client behavior
Jul 9, 2014
efe372c
Merge remote-tracking branch 'upstream/master'
Jul 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/main/java/com/github/dockerjava/client/command/BuildImgCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ public class BuildImgCmd extends AbstrDockerCmd<BuildImgCmd, ClientResponse> {
private InputStream tarInputStream = null;
private String tag;
private boolean noCache;
private boolean remove = true;
private boolean quiet;


public BuildImgCmd(File dockerFolder) {
Expand All @@ -68,11 +70,23 @@ public BuildImgCmd withNoCache(boolean noCache) {
return this;
}

public BuildImgCmd withRemove(boolean rm) {
this.remove = rm;
return this;
}

public BuildImgCmd withQuiet(boolean quiet) {
this.quiet = quiet;
return this;
}

@Override
public String toString() {
return new StringBuilder("build ")
.append(tag != null ? "-t " + tag + " " : "")
.append(noCache ? "--nocache=true " : "")
.append(quiet ? "--quiet=true " : "")
.append(!remove ? "--rm=false " : "")
.append(dockerFolder != null ? dockerFolder.getPath() : "-")
.toString();
}
Expand All @@ -98,6 +112,12 @@ protected ClientResponse callDocker(final InputStream dockerFolderTarInputStream
if (noCache) {
params.add("nocache", "true");
}
if (remove) {
params.add("rm", "true");
}
if (quiet) {
params.add("q", "true");
}

WebResource webResource = baseResource.path("/build").queryParams(params);

Expand Down