Add docker stats support#189
Add docker stats support#189marcuslinke merged 3 commits intodocker-java:masterfrom NirmataOSS:master
Conversation
Merge from upstream
Merge from upstream
Add docker stats support for 1.5+
|
+1, would love to see this as mainstream ! |
There was a problem hiding this comment.
This should not be needed. Could you remove this please?
There was a problem hiding this comment.
Well spotted !
Done.
Thanks !
On 7 Apr 2015 at 14:23:49, marcuslinke ([email protected]) wrote:
In src/test/java/com/github/dockerjava/client/AbstractDockerClientTest.java:
@@ -60,7 +60,7 @@ private DockerClientConfig config() {
protected DockerClientConfig config(String password) { DockerClientConfig.DockerClientConfigBuilder builder = DockerClientConfig.createDefaultConfigBuilder()
.withServerAddress("https://index.docker.io/v1/");.withServerAddress("https://index.docker.io/v1/").withMaxTotalConnections(5).withMaxPerRouteConnections(5);
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Hi Markus,
My apologies, I’m still quite new to github.
I believe it should be correct now.
Best regards,
Eric
On 7 Apr 2015 at 14:40:24, Eric Fjøsne ([email protected]) wrote:
Well spotted !
Done.
Thanks !
On 7 Apr 2015 at 14:23:49, marcuslinke ([email protected]) wrote:
In src/test/java/com/github/dockerjava/client/AbstractDockerClientTest.java:
@@ -60,7 +60,7 @@ private DockerClientConfig config() {
protected DockerClientConfig config(String password) { DockerClientConfig.DockerClientConfigBuilder builder = DockerClientConfig.createDefaultConfigBuilder()
.withServerAddress("https://index.docker.io/v1/");.withServerAddress("https://index.docker.io/v1/").withMaxTotalConnections(5).withMaxPerRouteConnections(5);
This should not be needed. Could you remove this please?
—
Reply to this email directly or view it on GitHub.
|
Is this ready to be merged or additional changes are required. Please let me know. |
|
Thank you! |
3 participants
Add docker stats support for docker 1.5+
It works in the same ways as events (async)
Also added a test case
@marcuslinke
Please review and merge