Dockerfiles not called 'dockerfile'#180
Merged
marcuslinke merged 1 commit intodocker-java:masterfrom Apr 1, 2015
magnayn:pr9
Merged
Dockerfiles not called 'dockerfile'#180marcuslinke merged 1 commit intodocker-java:masterfrom magnayn:pr9
marcuslinke merged 1 commit intodocker-java:masterfrom
magnayn:pr9
Conversation
Contributor
|
@magnayn I'm missing the advertised test case in your PR. Could you provide one please? |
Pass the name of the Dockerfile to docker. Adjust the TAR file to build from the correct path Implement some tests to show it working with a nonstandard name. Signed-off-by: Nigel Magnay <[email protected]>
Contributor
Author
|
Test added |
marcuslinke
added a commit
that referenced
this pull request
Apr 1, 2015
Dockerfiles not called 'dockerfile'
Contributor
|
@magnayn Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the name of the Dockerfile to docker (required or it doesn't know where to find it).
Adjust the TAR file to build from the correct path
Implement some tests to show it working with a nonstandard name.
Signed-off-by: Nigel Magnay [email protected]