Fix CreateContainerCmdImpl.withVolumesFrom()#114
Merged
marcuslinke merged 2 commits intodocker-java:masterfrom Dec 17, 2014
Merged
Fix CreateContainerCmdImpl.withVolumesFrom()#114marcuslinke merged 2 commits intodocker-java:masterfrom
marcuslinke merged 2 commits intodocker-java:masterfrom
Conversation
Another method that did not work until Docker Remote API 1.15, see CreateContainerCmd.withDns(). To fix it, the parameter had to be moved to nested HostConfig.
marcuslinke
added a commit
that referenced
this pull request
Dec 17, 2014
Fix CreateContainerCmdImpl.withVolumesFrom()
Contributor
|
@albers Thanks as always! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second (and last) parameter in
CreateContainerCmdthat did not work, the first beingDns, see #107.Resolution was the same as in #107: move the parameter into the nested
HostConfig.I had some trouble understanding how the
VolumesFromparameter is really handled in the creation and start steps, so I added some tests that verify my assumptions.