Allow to pass HostConfig when creating a container#105
Merged
marcuslinke merged 2 commits intodocker-java:masterfrom Dec 2, 2014
Merged
Allow to pass HostConfig when creating a container#105marcuslinke merged 2 commits intodocker-java:masterfrom
marcuslinke merged 2 commits intodocker-java:masterfrom
Conversation
* Move HostConfig into separate class * Use Links for container links instead of String * Add API for passing HostConfig when creating a container
Contributor
Contributor
|
there's a note about HostConfig being deprecated when starting a container, directly above the v.1.15 section:
|
Contributor
|
@gesellix I was referring to |
Contributor
|
@albers sorry, didn't see that here. So, just ignore my comments :) |
Contributor
|
@gesellix Thanks anyway! |
Contributor
|
LGTM |
marcuslinke
added a commit
that referenced
this pull request
Dec 2, 2014
Allow to pass HostConfig when creating a container
Contributor
|
@vjuranek Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HostConfigshould be passed when creating the container since API v1.15.HostConfiginto separate classStringHostConfigwhen creating a containerLinksandLink