Skip to content

Commit 351dac1

Browse files
committed
Merge pull request #22 from NirmataOSS/master
Fixes for startContainerCmd
2 parents af26a5d + 7acbfaa commit 351dac1

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/main/java/com/github/dockerjava/client/command/StartContainerCmd.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ protected Void impl() throws DockerException {
9797

9898
try {
9999
LOGGER.trace("POST: {}", webResource);
100-
Builder builder = webResource.accept(MediaType.TEXT_PLAIN);
100+
Builder builder = webResource.accept(MediaType.APPLICATION_JSON);
101101
if (startContainerConfig != null) {
102102
builder.type(MediaType.APPLICATION_JSON).post(startContainerConfig);
103103
} else {

src/test/java/com/github/dockerjava/client/command/StartContainerCmdTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ public void startContainerWithVolumes() throws DockerException {
8383
containerInspectResponse = dockerClient.inspectContainerCmd(container
8484
.getId()).exec();
8585

86+
8687
assertThat(Arrays.asList(containerInspectResponse.getVolumes()),
8788
contains(volume1, volume2));
8889

@@ -117,7 +118,7 @@ public void startContainerWithPortBindings() throws DockerException {
117118

118119
containerInspectResponse = dockerClient.inspectContainerCmd(container
119120
.getId()).exec();
120-
121+
121122
assertThat(Arrays.asList(containerInspectResponse.getConfig().getExposedPorts()),
122123
contains(tcp22, tcp23));
123124

@@ -190,7 +191,7 @@ public void startContainerWithLinking() throws DockerException {
190191
public void startContainer() throws DockerException {
191192

192193
ContainerCreateResponse container = dockerClient
193-
.createContainerCmd("busybox").withCmd("true").exec();
194+
.createContainerCmd("busybox").withCmd(new String[] { "top" }).exec();
194195

195196
LOG.info("Created container {}", container.toString());
196197
assertThat(container.getId(), not(isEmptyString()));

0 commit comments

Comments
 (0)