This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Add "eval" to every invocation of "docker-machine env"#795
Merged
ehazlett merged 1 commit intodocker-archive-public:masterfrom Mar 17, 2015
Merged
Add "eval" to every invocation of "docker-machine env"#795ehazlett merged 1 commit intodocker-archive-public:masterfrom
ehazlett merged 1 commit intodocker-archive-public:masterfrom
Conversation
See http://unix.stackexchange.com/a/181581 for the rationale behind this change. Signed-off-by: Andrew "Tianon" Page <[email protected]>
Contributor
|
LGTM |
Contributor
|
Thanks! |
ehazlett
added a commit
that referenced
this pull request
Mar 17, 2015
Add "eval" to every invocation of "docker-machine env"
Contributor
Author
|
❤️ |
This was referenced Mar 19, 2015
Closed
Contributor
|
This breaks the user experience. No one wants to run |
It's an edge case that is very confusing for newcomers. I think this is a good change. |
This was referenced Apr 22, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See http://unix.stackexchange.com/a/181581 for the rationale behind this change (ie, better compatibility in the future, especially if
envever has to get more complex logic performed within the user's shell, since a workaround for one of the issues this solves is already in place).See also moby/moby#11429, boot2docker/boot2docker#716, and boot2docker/boot2docker#786.