Add ip tunnel instructions readme #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aljones15
commented
Feb 2, 2024
aljones15
commented
- Adds a Table of Contents to the README more inline with a standard README
- Adds a Usage section to the README
- Adds a section in configuration on IP Tunnels
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 2 2
Lines 231 231
=======================================
Hits 213 213
Misses 18 18 Continue to review full report in Codecov by Sentry.
|
mattcollier
reviewed
Feb 2, 2024
README.md
Outdated
|
|
||
| In `config/server.js`: | ||
| ```js | ||
| // accept connections from any IP |
Contributor
There was a problem hiding this comment.
Binding a service to 0.0.0.0 means that your service will listen on all it's network interfaces.
Contributor
Author
There was a problem hiding this comment.
0.0.0.0 means a lot of different things I've found so thanks for the clarification. Made the change here: f9694da
dlongley
reviewed
Feb 2, 2024
| In `config/server.js`: | ||
| ```js | ||
| // accept connections from any interface on your device | ||
| config.server.domain = '0.0.0.0'; |
Member
There was a problem hiding this comment.
@mattcollier, it seems a little odd to me that this isn't using bindAddr here but domain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.