Merged
Conversation
ielvisd
approved these changes
Jan 23, 2019
Collaborator
ielvisd
left a comment
ielvisd
left a comment
There was a problem hiding this comment.
Great Job on all the array methods. I'm going to merge the branch but take a look at my comment for the callback problem.
| // Pass true to the callback if it is, otherwise pass false. | ||
| for (let i =0; i < item.length; i++) { | ||
|
|
||
| if (item[i] === list[i]){ |
Collaborator
There was a problem hiding this comment.
your checking if every item in items is equal to every item in lists which isn't what the comment is asking for here. you're supposed to check if an item is present in lists. So you'd be passing in Pencil for example that should return true but Apple would return false.
Owner
Author
There was a problem hiding this comment.
Ok I see what you mean, I misunderstood the question. Thank you for clarifying it, I have viewed it and corrected it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed MVP