Skip to content

test(defi): move event files to CDN#9563

Merged
gregorydemay merged 7 commits intomasterfrom
gdemay/DEFI-2703-move-events-to-cdn
Mar 27, 2026
Merged

test(defi): move event files to CDN#9563
gregorydemay merged 7 commits intomasterfrom
gdemay/DEFI-2703-move-events-to-cdn

Conversation

@gregorydemay
Copy link
Contributor

@gregorydemay gregorydemay commented Mar 24, 2026

Summary

  • Move ckBTC, ckETH, and ckDOGE minter event replay test files from checked-in test_resources/ to an external CDN (download.dfinity.systems/testdata/)
  • Update Rust test code to read event file paths from environment variables set by Bazel instead of constructing them from CARGO_MANIFEST_DIR

This reduces the repository size by removing large binary .gz files (~50 MB total).

🤖 Generated with Claude Code

@gregorydemay gregorydemay added the CI_ALL_BAZEL_TARGETS Runs all bazel targets label Mar 24, 2026
@gregorydemay gregorydemay changed the title build(defi): move event files to CDN test(defi): move event files to CDN Mar 24, 2026
@github-actions github-actions bot added the test label Mar 24, 2026
@gregorydemay gregorydemay marked this pull request as ready for review March 25, 2026 06:13
@gregorydemay gregorydemay requested review from a team as code owners March 25, 2026 06:13
Copy link
Collaborator

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I do agree with @mbjorkqvist's point that the filenames should have some timestamp included to indicate that they should not be overwritten when an update is required.

@gregorydemay gregorydemay enabled auto-merge March 27, 2026 08:26
@gregorydemay gregorydemay added this pull request to the merge queue Mar 27, 2026
Merged via the queue into master with commit 675a14c Mar 27, 2026
38 checks passed
@gregorydemay gregorydemay deleted the gdemay/DEFI-2703-move-events-to-cdn branch March 27, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants