fix false positive of virtual function call (danmar#3553)

nomick · web-flow · commit 5865b0570321 · 2021-11-11T07:53:30.000+01:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -2423,7 +2423,7 @@ void CheckClass::checkVirtualFunctionCallInConstructor()
                 continue;
             if (callstack.back()->function()->isPure())
                 pureVirtualFunctionCallInConstructorError(scope->function, callstack, callstack.back()->str());
-            else
+            else if (!callstack.back()->function()->hasFinalSpecifier())
                 virtualFunctionCallInConstructorError(scope->function, callstack, callstack.back()->str());
         }
     }
diff --git a/test/testclass.cpp b/test/testclass.cpp
@@ -6968,6 +6968,17 @@ class TestClass : public TestFixture {
                                  "    A() { f(); }\n"
                                  "};\n");
         ASSERT_EQUALS("", errout.str());
+
+        checkVirtualFunctionCall("class B {\n"
+                                 "public:"
+                                 "    virtual void f() {}\n"
+                                 "};\n"
+                                 "class A : B {\n"
+                                 "public:"
+                                 "    void f() override final {}\n"
+                                 "    A() { f(); }\n"
+                                 "};\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void pureVirtualFunctionCall() {

Original file line number	Diff line number	Diff line change
`@@ -2423,7 +2423,7 @@ void CheckClass::checkVirtualFunctionCallInConstructor()`
`2423`	`2423`	`continue;`
`2424`	`2424`	`if (callstack.back()->function()->isPure())`
`2425`	`2425`	`pureVirtualFunctionCallInConstructorError(scope->function, callstack, callstack.back()->str());`
`2426`		`- else`
	`2426`	`+ else if (!callstack.back()->function()->hasFinalSpecifier())`
`2427`	`2427`	`virtualFunctionCallInConstructorError(scope->function, callstack, callstack.back()->str());`
`2428`	`2428`	`}`
`2429`	`2429`	`}`