Skip to content

Crash on change graph file#444

Merged
rosaigor138 merged 2 commits into
mainfrom
216-crash-on-change-graph-file
Dec 6, 2023
Merged

Crash on change graph file#444
rosaigor138 merged 2 commits into
mainfrom
216-crash-on-change-graph-file

Conversation

@rosaigor138

@rosaigor138 rosaigor138 commented Nov 13, 2023

Copy link
Copy Markdown
Member

Closes #216

@rosaigor138 rosaigor138 added the bug Something isn't working label Nov 13, 2023
@rosaigor138 rosaigor138 self-assigned this Nov 13, 2023

@LBeghini LBeghini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the application, it worked perfectly. But the code need some changes.

Comment thread source/controller/wizard_controller.py Outdated
Comment thread source/controller/wizard_controller.py Outdated
@atilaajones

Copy link
Copy Markdown
Contributor

You should include the issue number in the description. This way we'll do a review to understand the motivation behind the update.

@rosaigor138 rosaigor138 requested a review from LBeghini November 22, 2023 18:35

@fsoupimenta fsoupimenta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on windows and ubuntu, and it worked fine

@atilaajones atilaajones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working on Windows.

@LBeghini LBeghini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on macOS Sonoma version 14.1.1 Chip Apple M1

@rosaigor138 rosaigor138 merged commit c1b5e61 into main Dec 6, 2023
@rosaigor138 rosaigor138 deleted the 216-crash-on-change-graph-file branch December 6, 2023 01:59
@atilaajones atilaajones restored the 216-crash-on-change-graph-file branch December 6, 2023 17:35
@atilaajones atilaajones deleted the 216-crash-on-change-graph-file branch December 6, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash on change graph file

4 participants