fix(lsp): resolve LSP server compilation errors#82
Merged
developerfred merged 3 commits intomainfrom Mar 20, 2026
Merged
Conversation
- build.rs: Fix unwrap in save() when cache_path has no parent - build.rs: Fix unwrap in build_file() when output has no parent - lib.rs: Fix unwrap in compile() when binary is None - Update dependencies: clap 4.4->4.5, regex 1.10->1.11, num_cpus 1.15->1.16
- Add lru_time_cache crate to bend-pvm-lsp dependencies - Update dependencies: clap 4.4->4.5, regex 1.10->1.11, num_cpus 1.15->1.16 Note: LSP server still needs API updates for lsp-types 0.94 compatibility
This was referenced Mar 20, 2026
Issues fixed: - #76: InlayHintParams naming (was InlayHintsParams) - #77: CodeActionKind::QUICKFIX (was QUICK_FIX) - #78: SemanticTokensOptions wrapped in SemanticTokensServerCapabilities - #79: CodeActionProviderCapability::Options wrapper - #80: ParseError variants (removed non-existent UnterminatedString/InvalidNumber) - #81: SymbolKind::CLASS (removed non-existent TYPE_ALIAS) Semantic tokens: - Return None for semantic tokens endpoints (API changed significantly) Parser errors: - Map to LexicalError and InvalidPattern for string/number errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes LSP server compilation errors that prevented building.
Issues Fixed
InlayHintParamsnaming (was incorrectly usingInlayHintsParams)CodeActionKind::QUICKFIX(API changed fromQUICK_FIX)SemanticTokensOptionswrapped properly withSemanticTokensServerCapabilitiesCodeActionProviderCapability::Optionswrapper for code action optionsParseErrorvariants - removed non-existentUnterminatedStringandInvalidNumber, mapped to existing variantsSymbolKind::CLASS(removed non-existentTYPE_ALIAS)Changes
Test Results