Skip to content

Commit 9a030ef

Browse files
jitsmasterjitsmaster
committed
Refactor visibleTransitionEnd triggering.
remove the sizingEnd event from areas, and have them directly invoke notify function on split component. Area was already tightly coupled with split component, so this is a better way to make thing happen.
1 parent 46ab05f commit 9a030ef

14 files changed

+84
-126
lines changed

‎dist/angularSplit.module.js‎

Lines changed: 16 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/angularSplit.module.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/index.js‎

Lines changed: 9 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/index.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/split.component.d.ts‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,12 @@ export declare class SplitComponent implements OnChanges, OnDestroy {
5151
hideArea(area: SplitAreaDirective): void;
5252
showArea(area: SplitAreaDirective): void;
5353
isLastVisibleArea(area: IAreaData): boolean;
54-
private _visibleTransitionEndTeardowns;
55-
private _addAreaSubscription(area);
56-
private _removeAreaSubscription(area);
5754
private refresh();
5855
private refreshStyleSizes();
5956
startDragging(startEvent: MouseEvent | TouchEvent, gutterOrder: number): void;
6057
private dragEvent(event, start, areaA, areaB);
6158
private drag(start, end, areaA, areaB);
6259
private stopDragging();
63-
private notify(type);
60+
notify(type: string): void;
6461
ngOnDestroy(): void;
6562
}

‎dist/split.component.js‎

Lines changed: 28 additions & 46 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)