Skip to content

Conversation

@slavikm
Copy link
Member

@slavikm slavikm commented Oct 6, 2025

Related Issues

Fixes https://github.com/descope/etc/issues/12340

Description

Add the FGA API whatCanTargetAccessWithRelation

Must

  • Tests
  • Documentation (if applicable)

Copilot AI review requested due to automatic review settings October 6, 2025 18:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Fine-Grained Authorization (FGA) API method whatCanTargetAccessWithRelation to filter resources by a specific relation definition and namespace. The implementation extends the existing authorization service with a more granular query capability.

  • Added new API endpoint for querying target access with relation filtering
  • Created new model class for handling resource responses
  • Enhanced the authorization service interface and implementation

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/main/java/com/descope/sdk/mgmt/AuthzService.java Added interface method with documentation for the new API
src/main/java/com/descope/sdk/mgmt/impl/AuthzServiceImpl.java Implemented the new method with validation and API call logic
src/main/java/com/descope/model/authz/ResourcesResponse.java Created new response model for resource lists
src/main/java/com/descope/literals/Routes.java Added new endpoint route constant
src/test/java/com/descope/sdk/mgmt/impl/AuthzServiceImplTest.java Added basic test case for the new functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@slavikm slavikm requested a review from Copilot October 6, 2025 18:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@slavikm slavikm requested review from gaokevin1 and gshriki October 6, 2025 18:54
@slavikm slavikm enabled auto-merge (squash) October 7, 2025 17:17
@slavikm slavikm merged commit 0c53996 into main Oct 7, 2025
16 checks passed
@slavikm slavikm deleted the fix/what-can-target-access-with-relation branch October 7, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants