chore: remove chromedriver dependency #4972
Draft
+78
−841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the dependency on
chromedriverentirely from the package. Now we check for the environment variable and if it isn't present we fail with a meaningful error message. Since this is only used in tests, it only impacts developers working in the project and not consumers of it.The contributing documentation has been updated to include information on how to get the needed binaries installed and configured.
Upon opening this PR, the Prettier check was failing. The reason for this was the dependencies were installed before node was setup on the version we run on locally. So Prettier was then expecting a newer node version then what it should be operating on. To fix this, I swapped the order of node-setup and
Install Dependenciesin the formatter workflow.No QA Required