add lib.node.d.ts types injection

dsherret · dsherret · commit 462776ec4db6 · 2025-12-03T14:18:24.000-05:00
diff --git a/src/compiler/deno.ts b/src/compiler/deno.ts
@@ -9,8 +9,8 @@ let typesNodeIgnorableNames = new Set<ts.__String>();
 export type EnterSpan = (name: string) => object;
 export type ExitSpan = (span: object) => void;
 
-export let enterSpan: EnterSpan = () => ({ });
-export let exitSpan: ExitSpan = () => { };
+export let enterSpan: EnterSpan = () => ({});
+export let exitSpan: ExitSpan = () => {};
 
 export function setEnterSpan(f: EnterSpan): void {
     enterSpan = f;
@@ -27,11 +27,12 @@ export function spanned<T>(name: string, f: () => T): T {
         if (result instanceof Promise) {
             needsExit = false;
             return result.finally(() => exitSpan(span)) as T;
-        } else {
+        }
+        else {
             return result;
         }
-
-    } finally {
+    }
+    finally {
         if (needsExit) {
             exitSpan(span);
         }
@@ -123,10 +124,6 @@ export function createDenoForkContext({
         return false;
     }
 
-    function isTypesNodePkgPath(path: ts.Path) {
-        return path.endsWith(".d.ts") && path.includes("/@types/node/");
-    }
-
     function createNodeGlobalsSymbolTable() {
         return new Proxy(globals, {
             get(target, prop: string | symbol, receiver) {
@@ -207,6 +204,10 @@ export function createDenoForkContext({
     }
 }
 
+export function isTypesNodePkgPath(path: ts.Path): boolean {
+    return path.endsWith(".d.ts") && path.includes("/@types/node/");
+}
+
 export interface NpmPackageReference {
     name: string;
     versionReq: string | undefined;
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -52,6 +52,7 @@ import {
     CustomTransformers,
     Debug,
     DeclarationWithTypeParameterChildren,
+    deno,
     Diagnostic,
     DiagnosticArguments,
     DiagnosticCategory,
@@ -1783,6 +1784,26 @@ export function createProgram(_rootNamesOrOptions: readonly string[] | CreatePro
         forEach(rootNames, (name, index) => processRootFile(name, /*isDefaultLib*/ false, /*ignoreNoDefaultLib*/ false, { kind: FileIncludeKind.RootFile, index }));
         tracing?.pop();
 
+        const nodeTypesLibUrl = "asset:///lib.node.d.ts" as Path;
+        const denoTypesLibUrl = "asset:///lib.deno.ns.d.ts" as Path;
+        const includeImplicitTypesNode = (() => {
+            // do not include if not has deno.ns lib or has node types lib already
+            if (!filesByName.has(denoTypesLibUrl) || filesByName.has(nodeTypesLibUrl)) {
+                return false;
+            }
+            // do not include if there is any @types/node package
+            for (const path of filesByName.keys()) {
+                if (deno.isTypesNodePkgPath(path)) {
+                    return false;
+                }
+            }
+            return true;
+        })();
+
+        if (includeImplicitTypesNode) {
+            processRootFile(nodeTypesLibUrl, /*isDefaultLib*/ true, /*ignoreNoDefaultLib*/ false, { kind: FileIncludeKind.LibFile });
+        }
+
         // load type declarations specified via 'types' argument or implicitly from types/ and node_modules/@types folders
         automaticTypeDirectiveNames ??= rootNames.length ? getAutomaticTypeDirectiveNames(options, host) : emptyArray;
         automaticTypeDirectiveResolutions = createModeAwareCache();
