Improve overflow handling in ZeRO #6976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@delock, @inkcherry, can you please help investigate the failing xpu-max1100 CI? Thanks! |
loadams
reviewed
Jan 30, 2025
Collaborator
@tjruwase thanks! Our engineer is looking into it. |
Signed-off-by: Olatunji Ruwase <[email protected]>
…o olruwase/ds_5241
Signed-off-by: Olatunji Ruwase <[email protected]>
…o olruwase/ds_5241
Signed-off-by: Olatunji Ruwase <[email protected]>
|
Any ETA on this for merge? |
Contributor
Author
|
loadams
approved these changes
Jun 9, 2025
deepcharm
pushed a commit
to deepcharm/DeepSpeed
that referenced
this pull request
Jun 16, 2025
Fix deepspeedai#5241: Improve overflow handling - [x] ZeRO 1 - [x] ZeRO 2 - [ ] ZeRO 3 - [ ] BF16Optimizer Enable pydantic configuration for mixed precision - [x] bf16 - [x] fp16 --------- Signed-off-by: Olatunji Ruwase <[email protected]> Signed-off-by: Fabien Dupont <[email protected]> Signed-off-by: Logan Adams <[email protected]> Signed-off-by: inkcherry <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Xinyu Lian <[email protected]> Co-authored-by: loadams <[email protected]> Co-authored-by: Omar Elayan <[email protected]> Co-authored-by: Fabio Geraci <[email protected]> Co-authored-by: Sam Foreman <[email protected]> Co-authored-by: Fabien Dupont <[email protected]> Co-authored-by: Liangliang Ma <[email protected]> Co-authored-by: inkcherry <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]> Signed-off-by: Max Kovalenko <[email protected]>
Antlera
pushed a commit
to Antlera/DeepSpeed
that referenced
this pull request
Jun 27, 2025
Fix deepspeedai#5241: Improve overflow handling - [x] ZeRO 1 - [x] ZeRO 2 - [ ] ZeRO 3 - [ ] BF16Optimizer Enable pydantic configuration for mixed precision - [x] bf16 - [x] fp16 --------- Signed-off-by: Olatunji Ruwase <[email protected]> Signed-off-by: Fabien Dupont <[email protected]> Signed-off-by: Logan Adams <[email protected]> Signed-off-by: inkcherry <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Xinyu Lian <[email protected]> Co-authored-by: loadams <[email protected]> Co-authored-by: Omar Elayan <[email protected]> Co-authored-by: Fabio Geraci <[email protected]> Co-authored-by: Sam Foreman <[email protected]> Co-authored-by: Fabien Dupont <[email protected]> Co-authored-by: Liangliang Ma <[email protected]> Co-authored-by: inkcherry <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]>
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
Fix deepspeedai#5241: Improve overflow handling - [x] ZeRO 1 - [x] ZeRO 2 - [ ] ZeRO 3 - [ ] BF16Optimizer Enable pydantic configuration for mixed precision - [x] bf16 - [x] fp16 --------- Signed-off-by: Olatunji Ruwase <[email protected]> Signed-off-by: Fabien Dupont <[email protected]> Signed-off-by: Logan Adams <[email protected]> Signed-off-by: inkcherry <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Xinyu Lian <[email protected]> Co-authored-by: loadams <[email protected]> Co-authored-by: Omar Elayan <[email protected]> Co-authored-by: Fabio Geraci <[email protected]> Co-authored-by: Sam Foreman <[email protected]> Co-authored-by: Fabien Dupont <[email protected]> Co-authored-by: Liangliang Ma <[email protected]> Co-authored-by: inkcherry <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5241: Improve overflow handling
Enable pydantic configuration for mixed precision