Add google cloud vision OCRDetector#328
Add google cloud vision OCRDetector#328paul-tharun wants to merge 4 commits intodeepdoctection:masterfrom
Conversation
|
Thanks for your PR, super happy to merge, once I get time reviewing this next week! 1.) Could you maybe add a small test? Something very similar to this would be very helpful. The API itself is mocked, it should be very straight forward. 2.) Could you add the google.cloud.vision dependency to the Thanks again. |
There was a problem hiding this comment.
Thanks again for your PR.
The code itself looks fine.
1.) Could you maybe add a small test? Something very similar to this would be very helpful. The API itself is mocked, it should be very straight forward.
2.) Could you add the google.cloud.vision dependency to the setup.py: additional_deps and _DEPS ? This will add yet another dependency, but I will have to refactor this anyway.
3.) Please check the remaining lint, mypy and test -issues:
https://github.com/deepdoctection/deepdoctection/actions/runs/8951911962/job/24629033613?pr=328
https://github.com/deepdoctection/deepdoctection/actions/runs/8951911962/job/24629034050?pr=328
https://github.com/deepdoctection/deepdoctection/actions/runs/8951911963/job/24629034108?pr=328
Thanks again.
2 participants
Added google cloud vision as OCR engine.
Implementation is similar to how the AWS TextractOCREngine is implemented