Fix clusters start for already active clusters#5538
Open
nanookclaw wants to merge 1 commit into
Open
Conversation
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
databricks clusters startdocuments that non-TERMINATEDclusters are a no-op, but the generated command forwards the backendINVALID_STATEerror returned for already-running clusters. This makes retry/idempotent start flows fail even when the cluster is already in a usable state.Changes
This adds a
startOverrideshook for the generated workspace clusters command. The generated start path still runs first, preserving normal argument parsing, request handling, waiting, and rendering. If that call returns HTTP 400INVALID_STATE, the override fetches the live cluster and returns success only when the cluster is confirmed non-TERMINATEDand not a job cluster. If the follow-up fetch fails, the cluster is still terminated, or the target is a job cluster, the original error is returned.Focused unit tests cover the already-running no-op case, normal start behavior with
--no-wait, preserving errors for terminated clusters, preserving errors when the follow-up get fails, and preserving the documented job-cluster error.Test plan
go test ./cmd/workspace/clusters./task fmt-q./task lint-qFixes #1372