Use latest review state in maintainer-approval#5323
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
janniklasrose
requested changes
Jun 9, 2026
Comment on lines
+60
to
+62
| // GitHub returns the full review history, so we collapse it to each user's | ||
| // latest state before evaluating whether the PR is currently approved. | ||
| function latestReviewsByUser(reviews) { |
Contributor
There was a problem hiding this comment.
this cannot just take all reviews.entries() but must only consider opinionated reviews (similar to GitHub's latestOpinionatedReviews API), i.e. APPROVED or CHANGES_REQUESTED.
Otherwise, an APPROVED followed by a COMMENTED will undo the approval. Needs to be covered by a unit test as well.
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The workflow currently treats historical
APPROVEDreviews as current approval. If a reviewer later switches toCHANGES_REQUESTED, the older approval can still satisfy the check.Fixes #5322.
Test plan
node --test .github/scripts/owners.test.js .github/workflows/maintainer-approval.test.js