[SQLite] Add a PQS option to test aggregate functions

mrigger · mrigger · commit a9abf279a1f8 · 2020-08-23T11:56:11.000+02:00
diff --git a/src/sqlancer/MainOptions.java b/src/sqlancer/MainOptions.java
@@ -65,6 +65,9 @@ public class MainOptions {
     @Parameter(names = "--print-succeeding-statements", description = "Print statements that are successfully processed by the DBMS to stdout (not yet implemented for all oracles)", arity = 1)
     private boolean printSucceedingStatements; // NOPMD
 
+    @Parameter(names = "--pqs-test-aggregates", description = "Partially test aggregate functions when all tables contain only a single row.")
+    private boolean testAggregateFunctions; // NOPMD
+
     public int getMaxExpressionDepth() {
         return maxExpressionDepth;
     }
@@ -146,4 +149,8 @@ public long getRandomSeed() {
         return randomSeed;
     }
 
+    public boolean testAggregateFunctionsPQS() {
+        return testAggregateFunctions;
+    }
+
 }
diff --git a/src/sqlancer/sqlite3/oracle/SQLite3PivotedQuerySynthesisOracle.java b/src/sqlancer/sqlite3/oracle/SQLite3PivotedQuerySynthesisOracle.java
@@ -97,7 +97,8 @@ public SQLite3Select getQuery() throws SQLException {
         allTables.addAll(tables);
         allTables.addAll(joinStatements.stream().map(join -> join.getTable()).collect(Collectors.toList()));
         boolean allTablesContainOneRow = allTables.stream().allMatch(t -> t.getNrRows() == 1);
-        pivotRowExpression = getColExpressions(allTablesContainOneRow, columns, columnsWithoutRowid);
+        boolean testAggregateFunctions = allTablesContainOneRow && globalState.getOptions().testAggregateFunctionsPQS();
+        pivotRowExpression = getColExpressions(testAggregateFunctions, columns, columnsWithoutRowid);
         selectStatement.setFetchColumns(pivotRowExpression);
         localState.log("queryTargetedColumnsString: "
                 + fetchColumns.stream().map(c -> c.getFullQualifiedName()).collect(Collectors.joining(", ")));
@@ -141,13 +142,13 @@ private List<Join> getJoinStatements(SQLite3GlobalState globalState, List<SQLite
         return joinStatements;
     }
 
-    private List<SQLite3Expression> getColExpressions(boolean allTablesContainOneRow, List<SQLite3Column> columns,
+    private List<SQLite3Expression> getColExpressions(boolean testAggregateFunctions, List<SQLite3Column> columns,
             List<SQLite3Column> columnsWithoutRowid) {
         List<SQLite3Expression> colExpressions = new ArrayList<>();
 
         for (SQLite3Column c : fetchColumns) {
             SQLite3Expression colName = new SQLite3ColumnName(c, pivotRow.getValues().get(c));
-            if (allTablesContainOneRow && Randomly.getBoolean()) {
+            if (testAggregateFunctions && Randomly.getBoolean()) {
 
                 /*
                  * PQS cannot detect omitted or incorrectly-fetched duplicate rows, so we can generate DISTINCT
@@ -174,7 +175,7 @@ private List<SQLite3Expression> getColExpressions(boolean allTablesContainOneRow
                 colExpressions.add(colName);
             }
         }
-        if (allTablesContainOneRow) {
+        if (testAggregateFunctions) {
             SQLite3WindowFunction windowFunction = SQLite3WindowFunction.getRandom(columnsWithoutRowid, globalState);
             SQLite3Expression windowExpr = generateWindowFunction(columnsWithoutRowid, windowFunction, false);
             colExpressions.add(windowExpr);

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,9 @@ public class MainOptions {`
`65`	`65`	`@Parameter(names = "--print-succeeding-statements", description = "Print statements that are successfully processed by the DBMS to stdout (not yet implemented for all oracles)", arity = 1)`
`66`	`66`	`private boolean printSucceedingStatements; // NOPMD`
`67`	`67`
	`68`	`+ @Parameter(names = "--pqs-test-aggregates", description = "Partially test aggregate functions when all tables contain only a single row.")`
	`69`	`+ private boolean testAggregateFunctions; // NOPMD`
	`70`	`+`
`68`	`71`	`public int getMaxExpressionDepth() {`
`69`	`72`	`return maxExpressionDepth;`
`70`	`73`	`}`
`@@ -146,4 +149,8 @@ public long getRandomSeed() {`
`146`	`149`	`return randomSeed;`
`147`	`150`	`}`
`148`	`151`
	`152`	`+ public boolean testAggregateFunctionsPQS() {`
	`153`	`+ return testAggregateFunctions;`
	`154`	`+ }`
	`155`	`+`
`149`	`156`	`}`