Use "wait" mode for acquiring connections from the pool in order to avoid

anthony-tuininga · anthony-tuininga · commit ab4cde01b76a · 2017-12-12T12:09:32.000-07:00
potential errors under certain circumstances.
diff --git a/test/SessionPool.py b/test/SessionPool.py
@@ -109,8 +109,10 @@ def testRollbackOnRelease(self):
 
     def testThreading(self):
         """test session pool to database with multiple threads"""
-        self.pool = cx_Oracle.SessionPool(USERNAME, PASSWORD, TNSENTRY, 5, 20,
-                2, threaded = True, encoding = ENCODING, nencoding = NENCODING)
+        self.pool = cx_Oracle.SessionPool(USERNAME, PASSWORD, TNSENTRY,
+                min = 5, max = 20, increment = 2, threaded = True,
+                getmode = cx_Oracle.SPOOL_ATTRVAL_WAIT, encoding = ENCODING,
+                nencoding = NENCODING)
         threads = []
         for i in range(20):
             thread = threading.Thread(None, self.__ConnectAndDrop)
@@ -121,8 +123,10 @@ def testThreading(self):
 
     def testThreadingWithErrors(self):
         """test session pool to database with multiple threads (with errors)"""
-        self.pool = cx_Oracle.SessionPool(USERNAME, PASSWORD, TNSENTRY, 5, 20,
-                2, threaded = True, encoding = ENCODING, nencoding = NENCODING)
+        self.pool = cx_Oracle.SessionPool(USERNAME, PASSWORD, TNSENTRY,
+                min = 5, max = 20, increment = 2, threaded = True,
+                getmode = cx_Oracle.SPOOL_ATTRVAL_WAIT, encoding = ENCODING,
+                nencoding = NENCODING)
         threads = []
         for i in range(20):
             thread = threading.Thread(None, self.__ConnectAndGenerateError)
