Let the same_sign helper work with integer dtypes

asmeurer · asmeurer · commit 1f70e0aa3615 · 2021-09-03T17:00:58.000-06:00
diff --git a/array_api_tests/array_helpers.py b/array_api_tests/array_helpers.py
@@ -106,20 +106,24 @@ def false(shape):
 
 def isnegzero(x):
     """
-    Returns a mask where x is -0.
+    Returns a mask where x is -0. Is all False if x has integer dtype.
     """
     # TODO: If copysign or signbit are added to the spec, use those instead.
     shape = x.shape
     dtype = x.dtype
+    if is_integer_dtype(dtype):
+        return false(shape)
     return equal(divide(one(shape, dtype), x), -infinity(shape, dtype))
 
 def isposzero(x):
     """
-    Returns a mask where x is +0 (but not -0).
+    Returns a mask where x is +0 (but not -0). Is all True if x has integer dtype.
     """
     # TODO: If copysign or signbit are added to the spec, use those instead.
     shape = x.shape
     dtype = x.dtype
+    if is_integer_dtype(dtype):
+        return true(shape)
     return equal(divide(one(shape, dtype), x), infinity(shape, dtype))
 
 def exactly_equal(x, y):
@@ -307,7 +311,6 @@ def same_sign(x, y):
 def assert_same_sign(x, y):
     assert all(same_sign(x, y)), "The input arrays do not have the same sign"
 
-
 integer_dtype_objects = [getattr(_array_module, t) for t in _integer_dtypes]
 floating_dtype_objects = [getattr(_array_module, t) for t in _floating_dtypes]
 numeric_dtype_objects = [getattr(_array_module, t) for t in _numeric_dtypes]
