Open
Conversation
mrbesen
force-pushed
the
handleItemName
branch
from
24eb1e9 to
f31aef4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was impossible to name an item. Now it should work. The next problem is sending the new named item to the player as the Item serialisation is not implemented yet.
See:
cuberite/src/Protocol/Protocol_1_13.cpp
Line 1581 in 5f4d2f0
A fast first test seems to indicate, that #5567 does not fix that. It seems like the NBT tags are written, but other kind of tags are expected for the item name.
Edit
This commit fixes the item names: mrbesen@189fc56