css_parse: flush trailing semicolons in CursorCompactWriteSink on drop by keithamus · Pull Request #908 · csskit/csskit

keithamus · 2026-03-01T11:18:45Z

Add a Drop impl that flushes pending semicolons at end-of-stream.
Previously, a trailing semicolon (e.g. @import "foo.css";) would be
swallowed because it was still in the pending slot when the sink was
dropped. Trailing whitespace remains discarded.

Also fix the redundant-semicolon KindSet: Colon was incorrectly listed
as a position where semicolons are redundant.

The Drop impl requires callers to scope the sink so it drops before the
output buffer is read — consumer updates follow in a separate commit.

github-actions

Some required steps failed!

github-actions

Some required steps failed!

github-actions

Some required steps failed!

Add a Drop impl that flushes pending semicolons at end-of-stream. Previously, a trailing semicolon (e.g. `@import "foo.css";`) would be swallowed because it was still in the pending slot when the sink was dropped. Trailing whitespace remains discarded. Also fix the redundant-semicolon KindSet: Colon was incorrectly listed as a position where semicolons are redundant. The Drop impl requires callers to scope the sink so it drops before the output buffer is read — consumer updates follow in a separate commit.

github-actions

All CI jobs have passed. Approving.

## [0.0.18] - 2026-03-01 ### Other Changes - Chore(deps): update rust crate toml to v1 (#875) ([#875](#875)) - Update css-tokenizer-tests (#887) ([#887](#887)) - Chore(deps): update dependencies (patch) (#900) ([#900](#900)) ### Chromashift - chromashift: Update to support wide-gamut color spaces, out of gamut colors (#877) ([#877](#877)) - chromashift: Implement css-color-4 raytrace gamut mapping (#879) ([#879](#879)) - chromashift: Increase precision of display-p3 to sRGB conversion (#897) ([#897](#897)) ### Css_ast - css_ast: Implement gap rule list (#878) ([#878](#878)) - Regenerate css_ast/src/values from csswg drafts (#881) ([#881](#881)) - css_ast: Implement ColorMix (#889) ([#889](#889)) - css_ast: Boxup more types (#890) ([#890](#890)) - Implement ColorFunctionColor::to_chromashift() and extract shortest_color helper (#898) ([#898](#898)) - Regenerate css_ast/src/values from csswg drafts (#899) ([#899](#899)) ### Css_lexer - css_lexer: Introduce UnicodeRange token kind. (#891) ([#891](#891)) - css_lexer: Add "Bad" tokens. (#892) ([#892](#892)) - css_lexer: Re-encode escapes in strings if they're invalid for unescaping (#894) ([#894](#894)) - css_lexer: Re-encode escapes in idents if they're invalid for unescaping (#896) ([#896](#896)) - css_lexer: Rewrite to use Bytes, memchr (#907) ([#907](#907)) ### Css_parse - css_parse: Add BumpBox type and blanket trait impls for Box types (#888) ([#888](#888)) - css_parse: flush trailing semicolons in CursorCompactWriteSink on drop (#908) ([#908](#908)) ### Csskit - chore(deps): update dependencies (patch) (#882) ([#882](#882)) ### Csskit_transform - csskit_transform: introduce css-minify-tests (#886) ([#886](#886)) - csskit_transform: snapshot css-minify-tests failures instead of asserting count (#893) ([#893](#893)) ### Csskit_vscode - chore(deps): update dependencies (minor) (#884) ([#884](#884)) - chore(deps): update dependencies to v1.49.0 (minor) (#901) ([#901](#901)) [forcebuild]

## [0.0.18] - 2026-03-01 ### Other Changes - Chore(deps): update rust crate toml to v1 (#875) ([#875](#875)) - Update css-tokenizer-tests (#887) ([#887](#887)) - Chore(deps): update dependencies (patch) (#900) ([#900](#900)) ### Chromashift - chromashift: Update to support wide-gamut color spaces, out of gamut colors (#877) ([#877](#877)) - chromashift: Implement css-color-4 raytrace gamut mapping (#879) ([#879](#879)) - chromashift: Increase precision of display-p3 to sRGB conversion (#897) ([#897](#897)) ### Css_ast - css_ast: Implement gap rule list (#878) ([#878](#878)) - Regenerate css_ast/src/values from csswg drafts (#881) ([#881](#881)) - css_ast: Implement ColorMix (#889) ([#889](#889)) - css_ast: Boxup more types (#890) ([#890](#890)) - Implement ColorFunctionColor::to_chromashift() and extract shortest_color helper (#898) ([#898](#898)) - Regenerate css_ast/src/values from csswg drafts (#899) ([#899](#899)) ### Css_lexer - css_lexer: Introduce UnicodeRange token kind. (#891) ([#891](#891)) - css_lexer: Add "Bad" tokens. (#892) ([#892](#892)) - css_lexer: Re-encode escapes in strings if they're invalid for unescaping (#894) ([#894](#894)) - css_lexer: Re-encode escapes in idents if they're invalid for unescaping (#896) ([#896](#896)) - css_lexer: Rewrite to use Bytes, memchr (#907) ([#907](#907)) ### Css_parse - css_parse: Add BumpBox type and blanket trait impls for Box types (#888) ([#888](#888)) - css_parse: flush trailing semicolons in CursorCompactWriteSink on drop (#908) ([#908](#908)) ### Csskit - chore(deps): update dependencies (patch) (#882) ([#882](#882)) ### Csskit_transform - csskit_transform: introduce css-minify-tests (#886) ([#886](#886)) - csskit_transform: snapshot css-minify-tests failures instead of asserting count (#893) ([#893](#893)) ### Csskit_vscode - chore(deps): update dependencies (minor) (#884) ([#884](#884)) - chore(deps): update dependencies to v1.49.0 (minor) (#901) ([#901](#901))

## [0.0.18] - 2026-03-01 ### Other Changes - Chore(deps): update rust crate toml to v1 (#875) ([#875](#875)) - Update css-tokenizer-tests (#887) ([#887](#887)) - Chore(deps): update dependencies (patch) (#900) ([#900](#900)) ### Chromashift - chromashift: Update to support wide-gamut color spaces, out of gamut colors (#877) ([#877](#877)) - chromashift: Implement css-color-4 raytrace gamut mapping (#879) ([#879](#879)) - chromashift: Increase precision of display-p3 to sRGB conversion (#897) ([#897](#897)) ### Css_ast - css_ast: Implement gap rule list (#878) ([#878](#878)) - Regenerate css_ast/src/values from csswg drafts (#881) ([#881](#881)) - css_ast: Implement ColorMix (#889) ([#889](#889)) - css_ast: Boxup more types (#890) ([#890](#890)) - Implement ColorFunctionColor::to_chromashift() and extract shortest_color helper (#898) ([#898](#898)) - Regenerate css_ast/src/values from csswg drafts (#899) ([#899](#899)) - css_ast: Remove StringOrUrl type (#909) ([#909](#909)) ### Css_lexer - css_lexer: Introduce UnicodeRange token kind. (#891) ([#891](#891)) - css_lexer: Add "Bad" tokens. (#892) ([#892](#892)) - css_lexer: Re-encode escapes in strings if they're invalid for unescaping (#894) ([#894](#894)) - css_lexer: Re-encode escapes in idents if they're invalid for unescaping (#896) ([#896](#896)) - css_lexer: Rewrite to use Bytes, memchr (#907) ([#907](#907)) ### Css_parse - css_parse: Add BumpBox type and blanket trait impls for Box types (#888) ([#888](#888)) - css_parse: flush trailing semicolons in CursorCompactWriteSink on drop (#908) ([#908](#908)) ### Csskit - chore(deps): update dependencies (patch) (#882) ([#882](#882)) ### Csskit_transform - csskit_transform: introduce css-minify-tests (#886) ([#886](#886)) - csskit_transform: snapshot css-minify-tests failures instead of asserting count (#893) ([#893](#893)) ### Csskit_vscode - chore(deps): update dependencies (minor) (#884) ([#884](#884)) - chore(deps): update dependencies to v1.49.0 (minor) (#901) ([#901](#901)) [forcebuild]

## [0.0.18] - 2026-03-01 ### Other Changes - Chore(deps): update rust crate toml to v1 (#875) ([#875](#875)) - Update css-tokenizer-tests (#887) ([#887](#887)) - Chore(deps): update dependencies (patch) (#900) ([#900](#900)) ### Chromashift - chromashift: Update to support wide-gamut color spaces, out of gamut colors (#877) ([#877](#877)) - chromashift: Implement css-color-4 raytrace gamut mapping (#879) ([#879](#879)) - chromashift: Increase precision of display-p3 to sRGB conversion (#897) ([#897](#897)) ### Css_ast - css_ast: Implement gap rule list (#878) ([#878](#878)) - Regenerate css_ast/src/values from csswg drafts (#881) ([#881](#881)) - css_ast: Implement ColorMix (#889) ([#889](#889)) - css_ast: Boxup more types (#890) ([#890](#890)) - Implement ColorFunctionColor::to_chromashift() and extract shortest_color helper (#898) ([#898](#898)) - Regenerate css_ast/src/values from csswg drafts (#899) ([#899](#899)) - css_ast: Remove StringOrUrl type (#909) ([#909](#909)) ### Css_lexer - css_lexer: Introduce UnicodeRange token kind. (#891) ([#891](#891)) - css_lexer: Add "Bad" tokens. (#892) ([#892](#892)) - css_lexer: Re-encode escapes in strings if they're invalid for unescaping (#894) ([#894](#894)) - css_lexer: Re-encode escapes in idents if they're invalid for unescaping (#896) ([#896](#896)) - css_lexer: Rewrite to use Bytes, memchr (#907) ([#907](#907)) ### Css_parse - css_parse: Add BumpBox type and blanket trait impls for Box types (#888) ([#888](#888)) - css_parse: flush trailing semicolons in CursorCompactWriteSink on drop (#908) ([#908](#908)) ### Csskit - chore(deps): update dependencies (patch) (#882) ([#882](#882)) ### Csskit_transform - csskit_transform: introduce css-minify-tests (#886) ([#886](#886)) - csskit_transform: snapshot css-minify-tests failures instead of asserting count (#893) ([#893](#893)) ### Csskit_vscode - chore(deps): update dependencies (minor) (#884) ([#884](#884)) - chore(deps): update dependencies to v1.49.0 (minor) (#901) ([#901](#901))

## [0.0.18] - 2026-03-01 ### Other Changes - Chore(deps): update rust crate toml to v1 (#875) ([#875](#875)) - Update css-tokenizer-tests (#887) ([#887](#887)) - Chore(deps): update dependencies (patch) (#900) ([#900](#900)) ### Chromashift - chromashift: Update to support wide-gamut color spaces, out of gamut colors (#877) ([#877](#877)) - chromashift: Implement css-color-4 raytrace gamut mapping (#879) ([#879](#879)) - chromashift: Increase precision of display-p3 to sRGB conversion (#897) ([#897](#897)) ### Css_ast - css_ast: Implement gap rule list (#878) ([#878](#878)) - Regenerate css_ast/src/values from csswg drafts (#881) ([#881](#881)) - css_ast: Implement ColorMix (#889) ([#889](#889)) - css_ast: Boxup more types (#890) ([#890](#890)) - Implement ColorFunctionColor::to_chromashift() and extract shortest_color helper (#898) ([#898](#898)) - Regenerate css_ast/src/values from csswg drafts (#899) ([#899](#899)) - css_ast: Remove StringOrUrl type (#909) ([#909](#909)) ### Css_lexer - css_lexer: Introduce UnicodeRange token kind. (#891) ([#891](#891)) - css_lexer: Add "Bad" tokens. (#892) ([#892](#892)) - css_lexer: Re-encode escapes in strings if they're invalid for unescaping (#894) ([#894](#894)) - css_lexer: Re-encode escapes in idents if they're invalid for unescaping (#896) ([#896](#896)) - css_lexer: Rewrite to use Bytes, memchr (#907) ([#907](#907)) ### Css_parse - css_parse: Add BumpBox type and blanket trait impls for Box types (#888) ([#888](#888)) - css_parse: flush trailing semicolons in CursorCompactWriteSink on drop (#908) ([#908](#908)) ### Csskit - chore(deps): update dependencies (patch) (#882) ([#882](#882)) ### Csskit_transform - csskit_transform: introduce css-minify-tests (#886) ([#886](#886)) - csskit_transform: snapshot css-minify-tests failures instead of asserting count (#893) ([#893](#893)) - csskit_transform: reduce Urls to Strings where possible (#910) ([#910](#910)) ### Csskit_vscode - chore(deps): update dependencies (minor) (#884) ([#884](#884)) - chore(deps): update dependencies to v1.49.0 (minor) (#901) ([#901](#901)) [forcebuild]

## [0.0.18] - 2026-03-01 ### Other Changes - Chore(deps): update rust crate toml to v1 (#875) ([#875](#875)) - Update css-tokenizer-tests (#887) ([#887](#887)) - Chore(deps): update dependencies (patch) (#900) ([#900](#900)) ### Chromashift - chromashift: Update to support wide-gamut color spaces, out of gamut colors (#877) ([#877](#877)) - chromashift: Implement css-color-4 raytrace gamut mapping (#879) ([#879](#879)) - chromashift: Increase precision of display-p3 to sRGB conversion (#897) ([#897](#897)) ### Css_ast - css_ast: Implement gap rule list (#878) ([#878](#878)) - Regenerate css_ast/src/values from csswg drafts (#881) ([#881](#881)) - css_ast: Implement ColorMix (#889) ([#889](#889)) - css_ast: Boxup more types (#890) ([#890](#890)) - Implement ColorFunctionColor::to_chromashift() and extract shortest_color helper (#898) ([#898](#898)) - Regenerate css_ast/src/values from csswg drafts (#899) ([#899](#899)) - css_ast: Remove StringOrUrl type (#909) ([#909](#909)) ### Css_lexer - css_lexer: Introduce UnicodeRange token kind. (#891) ([#891](#891)) - css_lexer: Add "Bad" tokens. (#892) ([#892](#892)) - css_lexer: Re-encode escapes in strings if they're invalid for unescaping (#894) ([#894](#894)) - css_lexer: Re-encode escapes in idents if they're invalid for unescaping (#896) ([#896](#896)) - css_lexer: Rewrite to use Bytes, memchr (#907) ([#907](#907)) ### Css_parse - css_parse: Add BumpBox type and blanket trait impls for Box types (#888) ([#888](#888)) - css_parse: flush trailing semicolons in CursorCompactWriteSink on drop (#908) ([#908](#908)) ### Csskit - chore(deps): update dependencies (patch) (#882) ([#882](#882)) ### Csskit_transform - csskit_transform: introduce css-minify-tests (#886) ([#886](#886)) - csskit_transform: snapshot css-minify-tests failures instead of asserting count (#893) ([#893](#893)) - csskit_transform: reduce Urls to Strings where possible (#910) ([#910](#910)) ### Csskit_vscode - chore(deps): update dependencies (minor) (#884) ([#884](#884)) - chore(deps): update dependencies to v1.49.0 (minor) (#901) ([#901](#901))

keithamus enabled auto-merge (squash) March 1, 2026 11:18

keithamus disabled auto-merge March 1, 2026 11:19

keithamus force-pushed the csskit-csskit-wasm-csskit-transform-drop-cursorcompactwritesink-at-all-call-sites branch from f93786f to 8cc5be7 Compare March 1, 2026 11:21

keithamus changed the title ~~csskit csskit wasm csskit transform drop cursorcompactwritesink at all call sites~~ css_parse: flush trailing semicolons in CursorCompactWriteSink on drop Mar 1, 2026

keithamus enabled auto-merge (squash) March 1, 2026 11:21

github-actions bot requested changes Mar 1, 2026

View reviewed changes

keithamus force-pushed the csskit-csskit-wasm-csskit-transform-drop-cursorcompactwritesink-at-all-call-sites branch from 8cc5be7 to ab86478 Compare March 1, 2026 11:27

github-actions bot requested changes Mar 1, 2026

View reviewed changes

keithamus force-pushed the csskit-csskit-wasm-csskit-transform-drop-cursorcompactwritesink-at-all-call-sites branch from ab86478 to 6a5ca17 Compare March 1, 2026 12:26

github-actions bot approved these changes Mar 1, 2026

View reviewed changes

keithamus merged commit 0d1d0a9 into main Mar 1, 2026
17 checks passed

keithamus deleted the csskit-csskit-wasm-csskit-transform-drop-cursorcompactwritesink-at-all-call-sites branch March 1, 2026 12:32

keithamus mentioned this pull request Mar 1, 2026

Release v0.0.18 #876

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

css_parse: flush trailing semicolons in CursorCompactWriteSink on drop#908

css_parse: flush trailing semicolons in CursorCompactWriteSink on drop#908
keithamus merged 1 commit intomainfrom
csskit-csskit-wasm-csskit-transform-drop-cursorcompactwritesink-at-all-call-sites

keithamus commented Mar 1, 2026 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

keithamus commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

keithamus commented Mar 1, 2026 •

edited

Loading