Merged
Conversation
AlignSelfStyleValue recently changed syntax to allow the `normal` keyword, or self-position. This caused us to have to comment this out in #851. So this is obviously something we need to fix. Turns out `normal` is a common keyword just like `auto` and `none`, which feels like enough of a motivation to get its own wrapper type akin to those. So this change introduces a new `NormalOr<>` generic to allow parsing of align-self again. While we're here, we also uncomment `ItemPackStyleValue` and `TextBoxStyleValue` as they're trivial to uncomment with this new generic.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
keithamus
added a commit
that referenced
this pull request
Feb 3, 2026
…tyleValue These two types leverage the new `NormalOr<>` generic type added in #861, plus a couple of new types which are simple enough to implement.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
## [0.0.17] - 2026-02-04 ### Css_ast - css_ast: Uncomment FlexStyleValue (#860) ([#860](#860)) - Regenerate css_ast/src/values from csswg drafts (#851) ([#851](#851)) - css_ast: Add NormalOr<> generic. (#861) ([#861](#861)) - css_ast: Enable FontFeatureSettingsStyleValue, FontVariationSettingsStyleValue (#862) ([#862](#862)) ### Csskit - chore(deps): update dependencies (patch) (#852) ([#852](#852)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.42.0 (#855) ([#855](#855)) [forcebuild]
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
## [0.0.17] - 2026-02-04 ### Css_ast - css_ast: Uncomment FlexStyleValue (#860) ([#860](#860)) - Regenerate css_ast/src/values from csswg drafts (#851) ([#851](#851)) - css_ast: Add NormalOr<> generic. (#861) ([#861](#861)) - css_ast: Enable FontFeatureSettingsStyleValue, FontVariationSettingsStyleValue (#862) ([#862](#862)) ### Csskit - chore(deps): update dependencies (patch) (#852) ([#852](#852)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.42.0 (#855) ([#855](#855))
github-actions bot
pushed a commit
that referenced
this pull request
Feb 9, 2026
## [0.0.17] - 2026-02-09 ### Css_ast - css_ast: Uncomment FlexStyleValue (#860) ([#860](#860)) - Regenerate css_ast/src/values from csswg drafts (#851) ([#851](#851)) - css_ast: Add NormalOr<> generic. (#861) ([#861](#861)) - css_ast: Enable FontFeatureSettingsStyleValue, FontVariationSettingsStyleValue (#862) ([#862](#862)) ### Csskit - chore(deps): update dependencies (patch) (#852) ([#852](#852)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.42.0 (#855) ([#855](#855)) - chore(deps): update dependencies (patch) (#864) ([#864](#864)) - chore(deps): update dependency oxlint to v1.43.0 (#867) ([#867](#867)) - chore(deps): update dependency @types/vscode to v1.109.0 (#865) ([#865](#865)) [forcebuild]
github-actions bot
pushed a commit
that referenced
this pull request
Feb 9, 2026
## [0.0.17] - 2026-02-09 ### Css_ast - css_ast: Uncomment FlexStyleValue (#860) ([#860](#860)) - Regenerate css_ast/src/values from csswg drafts (#851) ([#851](#851)) - css_ast: Add NormalOr<> generic. (#861) ([#861](#861)) - css_ast: Enable FontFeatureSettingsStyleValue, FontVariationSettingsStyleValue (#862) ([#862](#862)) ### Csskit - chore(deps): update dependencies (patch) (#852) ([#852](#852)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.42.0 (#855) ([#855](#855)) - chore(deps): update dependencies (patch) (#864) ([#864](#864)) - chore(deps): update dependency oxlint to v1.43.0 (#867) ([#867](#867)) - chore(deps): update dependency @types/vscode to v1.109.0 (#865) ([#865](#865))
github-actions bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
## [0.0.17] - 2026-02-11 ### Css_ast - css_ast: Uncomment FlexStyleValue (#860) ([#860](#860)) - Regenerate css_ast/src/values from csswg drafts (#851) ([#851](#851)) - css_ast: Add NormalOr<> generic. (#861) ([#861](#861)) - css_ast: Enable FontFeatureSettingsStyleValue, FontVariationSettingsStyleValue (#862) ([#862](#862)) - css_ast: Fixup container queries (#874) ([#874](#874)) - css_ast: Support custom scroll state queries (#873) ([#873](#873)) - Regenerate css_ast/src/values from csswg drafts (#863) ([#863](#863)) ### Csskit - chore(deps): update dependencies (patch) (#852) ([#852](#852)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.42.0 (#855) ([#855](#855)) - chore(deps): update dependencies (patch) (#864) ([#864](#864)) - chore(deps): update dependency oxlint to v1.43.0 (#867) ([#867](#867)) - chore(deps): update dependency @types/vscode to v1.109.0 (#865) ([#865](#865)) [forcebuild]
github-actions bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
## [0.0.17] - 2026-02-11 ### Css_ast - css_ast: Uncomment FlexStyleValue (#860) ([#860](#860)) - Regenerate css_ast/src/values from csswg drafts (#851) ([#851](#851)) - css_ast: Add NormalOr<> generic. (#861) ([#861](#861)) - css_ast: Enable FontFeatureSettingsStyleValue, FontVariationSettingsStyleValue (#862) ([#862](#862)) - css_ast: Fixup container queries (#874) ([#874](#874)) - css_ast: Support custom scroll state queries (#873) ([#873](#873)) - Regenerate css_ast/src/values from csswg drafts (#863) ([#863](#863)) ### Csskit - chore(deps): update dependencies (patch) (#852) ([#852](#852)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.42.0 (#855) ([#855](#855)) - chore(deps): update dependencies (patch) (#864) ([#864](#864)) - chore(deps): update dependency oxlint to v1.43.0 (#867) ([#867](#867)) - chore(deps): update dependency @types/vscode to v1.109.0 (#865) ([#865](#865))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AlignSelfStyleValue recently changed syntax to allow the
normalkeyword, orself-position. This caused us to have to comment this out in #851. So this is
obviously something we need to fix.
Turns out
normalis a common keyword just likeautoandnone, which feelslike enough of a motivation to get its own wrapper type akin to those. So this
change introduces a new
NormalOr<>generic to allow parsing of align-selfagain. While we're here, we also uncomment
ItemPackStyleValueandTextBoxStyleValueas they're trivial to uncomment with this new generic.