Conversation
ebdab96 to
735da24
Compare
02f037e to
07ef539
Compare
keithamus
left a comment
There was a problem hiding this comment.
Really excellent work! This will have a large knock-on impact for parsing a lot of new values, plus display itself is an incredibly popular property so we really need to get it parsing!
There are a few things that need to change, but mostly small, plus some commentary for follow up work:
| format_ident!( | ||
| "{}", | ||
| ds.iter().fold(String::new(), |str, d| match d { | ||
| Def::Type(d) => { | ||
| format!("{}{}", str, d.to_variant_name(0)) | ||
| } | ||
| _ => { | ||
| dbg!("TODO variant name for Combinator() of Options", d); | ||
| todo!("variant name") | ||
| } | ||
| }) | ||
| ) |
There was a problem hiding this comment.
As a nice follow up (not needed for this PR) it might be useful to take the generated name (DisplayInsideDisplayOutside) and map it via a toml file into a nicer name. In this case this name is probably okay but DisplayInsideOutside or DisplayMultiKeyword or some other such name would probably make more sense, and while I think this is a reasonable heuristic which might get us far, I also worry that some names will end up extremely burdensome, for example PositionVisibilityStyleValue has always | [ anchors-valid || anchors-visible || no-overflow ] which would end up being AnchorsValidAnchorsVisibileNoOverflow which is a mouthful when it could be PositionVisibilityKeyword or so.
This will matter because each of these generated values is mapped to a node ID which makes it selectable via rule sheets, and the names should be clear and self explanatory there.
keithamus
left a comment
There was a problem hiding this comment.
Thanks for double checking me on the &&, you were totally right!
In that case the comments here are mostly nits, so this can be merged unless you want to follow up and address e.g. the test ordering and attempt derive?
## [0.0.14] - 2026-01-07 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) [forcebuild]
## [0.0.14] - 2026-01-07 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791))
…nerated types cf9af93 (#799) introduced the auto generation of group names based on the underlying types in the group, for example `[ <foo> || <bar> ]` would generate the type `FooBar`. This is mostly fine, except those auto generated names could become gnarly, quickly, for example `PositionVisibilityStyleValue` has `always | [ anchors-valid || anchors-visible || no-overflow ]` which would end generating a `AnchorsValidAnchorsVisibileNoOverflow` type which is a mouthful when it could be `PositionVisibilityKeyword` or so. Even in that that PR, `DisplayOutsideDisplayInside` was a generated node, which could be more nicely written as `DisplayOutsideInside`. This change tries to alleviate some of these potential issues by creating a map driven via toml, which maps potentially less desirable names to a more desirable equivalent. The first entry being `DisplayOutsideDisplayInside` to `DisplayOutsideInside`.
…nerated types (#800) cf9af93 (#799) introduced the auto generation of group names based on the underlying types in the group, for example `[ <foo> || <bar> ]` would generate the type `FooBar`. This is mostly fine, except those auto generated names could become gnarly, quickly, for example `PositionVisibilityStyleValue` has `always | [ anchors-valid || anchors-visible || no-overflow ]` which would end generating a `AnchorsValidAnchorsVisibileNoOverflow` type which is a mouthful when it could be `PositionVisibilityKeyword` or so. Even in that that PR, `DisplayOutsideDisplayInside` was a generated node, which could be more nicely written as `DisplayOutsideInside`. This change tries to alleviate some of these potential issues by creating a map driven via toml, which maps potentially less desirable names to a more desirable equivalent. The first entry being `DisplayOutsideDisplayInside` to `DisplayOutsideInside`.
## [0.0.14] - 2026-01-07 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) [forcebuild]
## [0.0.14] - 2026-01-07 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791))
## [0.0.14] - 2026-01-12 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) [forcebuild]
## [0.0.14] - 2026-01-12 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805))
## [0.0.14] - 2026-01-12 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802)) [forcebuild]
## [0.0.14] - 2026-01-12 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802))
## [0.0.14] - 2026-01-12 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802)) [forcebuild]
## [0.0.14] - 2026-01-12 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802))
## [0.0.14] - 2026-01-14 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802)) [forcebuild]
## [0.0.14] - 2026-01-14 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802))
## [0.0.14] - 2026-01-14 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802)) ### Csskit_wasm - website: fix pages deploy (#807) ([#807](#807)) [forcebuild]
## [0.0.14] - 2026-01-14 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802)) ### Csskit_wasm - website: fix pages deploy (#807) ([#807](#807))
## [0.0.14] - 2026-01-19 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) - Regenerate css_ast/src/values from csswg drafts (#808) ([#808](#808)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802)) - fix(deps): update dependencies (patch) (#809) ([#809](#809)) - chore(deps): update dependency oxlint to v1.39.0 (#811) ([#811](#811)) ### Csskit_wasm - website: fix pages deploy (#807) ([#807](#807)) [forcebuild]
## [0.0.14] - 2026-01-19 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) - Regenerate css_ast/src/values from csswg drafts (#808) ([#808](#808)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802)) - fix(deps): update dependencies (patch) (#809) ([#809](#809)) - chore(deps): update dependency oxlint to v1.39.0 (#811) ([#811](#811)) ### Csskit_wasm - website: fix pages deploy (#807) ([#807](#807))
## [0.0.14] - 2026-01-19 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) - Regenerate css_ast/src/values from csswg drafts (#808) ([#808](#808)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802)) - fix(deps): update dependencies (patch) (#809) ([#809](#809)) - chore(deps): update dependency oxlint to v1.39.0 (#811) ([#811](#811)) - chore(deps): update dependency prettier to v3.8.0 (#813) ([#813](#813)) ### Csskit_wasm - website: fix pages deploy (#807) ([#807](#807)) [forcebuild]
## [0.0.14] - 2026-01-19 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) - Regenerate css_ast/src/values from csswg drafts (#808) ([#808](#808)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802)) - fix(deps): update dependencies (patch) (#809) ([#809](#809)) - chore(deps): update dependency oxlint to v1.39.0 (#811) ([#811](#811)) - chore(deps): update dependency prettier to v3.8.0 (#813) ([#813](#813)) ### Csskit_wasm - website: fix pages deploy (#807) ([#807](#807))
## [0.0.14] - 2026-01-22 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) - Regenerate css_ast/src/values from csswg drafts (#808) ([#808](#808)) - csskit_transform: Reduce more color types (#818) ([#818](#818)) - csskit_transform: Add ReduceTimeUnits transform (#819) ([#819](#819)) - css_ast/css_transform: Only reduce lengths to unitless zero when applicable (#821) ([#821](#821)) - csskit_spec_generator/css_ast: Generate many more values (#823) ([#823](#823)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Css_parse - csskit/csskit_transform/css_parse: Improve transform architecture. Minify lengths (#815) ([#815](#815)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_transform - csskit_transform: Add Reduce colors (#816) ([#816](#816)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802)) - fix(deps): update dependencies (patch) (#809) ([#809](#809)) - chore(deps): update dependency oxlint to v1.39.0 (#811) ([#811](#811)) - chore(deps): update dependency prettier to v3.8.0 (#813) ([#813](#813)) ### Csskit_wasm - website: fix pages deploy (#807) ([#807](#807)) - csskit_wasm: Use minifier transform architecture (#817) ([#817](#817)) [forcebuild]
## [0.0.14] - 2026-01-22 ### Other Changes - Coverage: Add `:unknown` coverage testing to all popular CSS libraries (#796) ([#796](#796)) ### Chromashift - chromashift: Fix lossy alpha conversions (#784) ([#784](#784)) ### Css_ast - Regenerate css_ast/src/values from csswg drafts (#789) ([#789](#789)) - css_ast: Fixup MediaQueryList & ContainerConditionList to use CommaSeparated (#795) ([#795](#795)) - css_ast: Add support for parsing `@import` rules (#797) ([#797](#797)) - css_ast: enables `<display>` (#799) ([#799](#799)) - css_ast/csskit_proc_macro: Provide system for easily renaming auto-generated types (#800) ([#800](#800)) - Regenerate css_ast/src/values from csswg drafts (#801) ([#801](#801)) - Regenerate css_ast/src/values from csswg drafts (#808) ([#808](#808)) - csskit_transform: Reduce more color types (#818) ([#818](#818)) - csskit_transform: Add ReduceTimeUnits transform (#819) ([#819](#819)) - css_ast/css_transform: Only reduce lengths to unitless zero when applicable (#821) ([#821](#821)) - csskit_spec_generator/css_ast: Generate many more values (#823) ([#823](#823)) ### Css_lexer - css_lexer/css_parse: Add SourceCursor compacting, ensure CursorCompactWriteSink compacts cursors before write (#782) ([#782](#782)) ### Css_parse - csskit/csskit_transform/css_parse: Improve transform architecture. Minify lengths (#815) ([#815](#815)) ### Csskit - chore(deps): update dependencies (patch) (#790) ([#790](#790)) ### Csskit_ast - csskit_ast: Add benchmarks for linting with example cks files (#788) ([#788](#788)) ### Csskit_transform - csskit_transform: Add Reduce colors (#816) ([#816](#816)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.36.0 (#791) ([#791](#791)) - chore(deps): update dependency @types/vscode to v1.108.1 (#803) ([#803](#803)) - chore(deps): update dependency oxlint to v1.38.0 (#805) ([#805](#805)) - chore(deps): update dependencies (patch) (#802) ([#802](#802)) - fix(deps): update dependencies (patch) (#809) ([#809](#809)) - chore(deps): update dependency oxlint to v1.39.0 (#811) ([#811](#811)) - chore(deps): update dependency prettier to v3.8.0 (#813) ([#813](#813)) ### Csskit_wasm - website: fix pages deploy (#807) ([#807](#807)) - csskit_wasm: Use minifier transform architecture (#817) ([#817](#817))
This PR implements the
DisplayStyleValue, and dependant display types. We did need to expect the proc_macros to support a Combinator of Options, so did that in this diff as well.