Skip to content

fix(braces): F+ for ; after {} in struct/union reference #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronliu0130 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix(braces): F+ for ; after {} in struct/union reference #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3121559
fix(braces): false positive for ; after {} in struct reference
aaronliu0130 Jul 21, 2025
95d32b0
apply to union as well
aaronliu0130 Nov 28, 2025
a44637e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cpplint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5055,6 +5055,7 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
# - Compound literals
# - Lambdas
# - alignas specifier with anonymous structs
# - references to anonymous struct or union
# - decltype
# - concepts (requires expression)
closing_brace_pos = match.group(1).rfind(")")
Expand All @@ -5080,6 +5081,12 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
)
)
or (func and not re.search(r"\boperator\s*\[\s*\]", func.group(1)))
or (
re.search(r"&\s*$", line_prefix)
and re.match(
r"(?:struct|union)\s", opening_parenthesis[0][opening_parenthesis[2] + 1 :]
)
)
or re.search(r"\b(?:struct|union)\s+alignas\s*$", line_prefix)
or re.search(r"\bdecltype$", line_prefix)
or re.search(r"\brequires.*$", line_prefix)
Expand Down
1 change: 1 addition & 0 deletions cpplint_unittest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3062,6 +3062,7 @@ def testSemiColonAfterBraces(self):
for identifier in ["", " x"]:
self.TestLint(keyword + align + typename + " {}" + identifier + ";", "")

self.TestLint("struct mount_attr *attr = &(struct mount_attr){};", "")
Comment thread
aaronliu0130 marked this conversation as resolved.
self.TestLint("class X : public Y {};", "")
self.TestLint("class X : public MACRO() {};", "")
self.TestLint("class X : public decltype(expr) {};", "")
Expand Down