Skip to content

All TODOs in Python code should have a username #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronliu0130 merged 2 commits into from
Mar 31, 2025
Merged

All TODOs in Python code should have a username #355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cc0092
All TODOs should have a username
cclauss Mar 30, 2025
377f2c2
actually add usernames to todos
aaronliu0130 Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpplint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4245,7 +4245,7 @@ def CheckOperatorSpacing(filename, clean_lines, linenum, error):
# many false positives due to RValue references.
match = re.search(r"[^<>=!\s](==|!=|<=|>=|\|\|)[^<>=!\s,;\)]", line)
if match:
# TODO: support alternate operators
# TODO(unknown): support alternate operators
error(
filename, linenum, "whitespace/operators", 3, f"Missing spaces around {match.group(1)}"
)
Expand Down Expand Up @@ -4767,7 +4767,7 @@ def CheckBraces(filename, clean_lines, linenum, error):
" should be on a separate line",
)

# TODO: Err on if...else and do...while statements without braces;
# TODO(unknown): Err on if...else and do...while statements without braces;
# style guide has changed since the below comment was written

# Check single-line if/else bodies. The style guide says 'curly braces are not
Expand Down Expand Up @@ -7457,7 +7457,7 @@ def ProcessFile(filename, vlevel, extra_check_functions=None):
lf_lines.append(linenum + 1)

except OSError:
# TODO: Maybe make this have an exit code of 2 after all is done
# TODO(unknown): Maybe make this have an exit code of 2 after all is done
_cpplint_state.PrintError(f"Skipping input '{filename}': Can't open for reading\n")
_RestoreFilters()
return
Expand Down
2 changes: 1 addition & 1 deletion cpplint_clitest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def run_shell_command(cmd: str, args: str, cwd: str = ".") -> tuple[int, bytes,

# Make output system-agnostic, aka support Windows
if os.sep == "\\":
# TODO: Support scenario with multiple input names
# TODO(unknown): Support scenario with multiple input names
# We currently only support the last arguments as the input name
# to prevent accidentally replacing sed tests.
# Fixing would likely need coding an internal "replace slashes" option for cpplint itself.
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ lint.select = [
"SLOT", # flake8-slots
"T10", # flake8-debugger
"TC", # flake8-type-checking
"TD", # flake8-todos
"TID", # flake8-tidy-imports
"TRY", # tryceratops
"UP", # pyupgrade
Expand All @@ -122,13 +123,13 @@ lint.select = [
# "S", # flake8-bandit
# "SLF", # flake8-self
# "T20", # flake8-print
# "TD", # flake8-todos
]
lint.ignore = [
"FBT003", # flake8-boolean-trap
"FIX002", # flake8-fixme
"ISC003", # flake8-implicit-str-concat
"PIE790", # Unnecessary `pass` statement
"TD003", # flake8-todos
Comment thread
cclauss marked this conversation as resolved.
]
lint.per-file-ignores."cpplint.py" = [
"ICN001",
Expand Down
Loading