Conversation
y-lakhdar
requested review from
a team,
btaillon-coveo,
hdhayneCoveo,
louis-bompart and
olamothe
and removed request for
a team
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
samisayegh
approved these changes
May 19, 2023
btaillon-coveo
approved these changes
May 23, 2023
Co-authored-by: Benjamin Taillon <[email protected]>
y-lakhdar
added a commit
that referenced
this pull request
May 25, 2023
Update src/main/java/com/coveo/pushapiclient/ApiUrl.java Co-authored-by: Benjamin Taillon <[email protected]> add new getter to source classes feat: create `PushSource` and `catalogSource` classes (#30) https://coveord.atlassian.net/browse/LENS-839 update StreamService add platformClient tests add PowerMockito dependencies remove unused import remove unecessary method downgrade build to Java 11 revert codeql deletion lint lint
y-lakhdar
added a commit
that referenced
this pull request
Jun 20, 2023
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created
PushSourceandCatalogSourceclasses.Both classes are not publicly exposed until the StreamService and PushService are implemented.
Once public, the
Sourceclass can be deprecated in favour of the newPushSourceclass.Notable changes for these classes:
StreamEnabledSourceorPushEnabledSource(or both) so they can use the appropriate upload service.