Conversation
dmbrooke
requested review from
a team,
mrrajamanickam-coveo,
olamothe and
y-lakhdar
and removed request for
a team
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Filespom.xml
|
olamothe
requested changes
Sep 6, 2023
y-lakhdar
reviewed
Sep 11, 2023
y-lakhdar
requested changes
Sep 11, 2023
olamothe
approved these changes
Sep 11, 2023
y-lakhdar
reviewed
Sep 11, 2023
y-lakhdar
approved these changes
Sep 12, 2023
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer, this is my first time working with Java in 5-ish years, so I'm very open to suggestions that use more common design principles. Also note that I couldn't figure out a way to ensure that the
timeMultiple/retryAfterproperties were sleeping for the correct amount of time on each iteration, so I only test that themaxRetriesproperty is being enforced.With that out of the way, here's exponential backoff for all outgoing requests from the APICore class. I also made sure that implementers are able to configure the backoff options on all classes that leverage the APICore.
Finally, I added a BackOffOptionsBuilder class to ensure there is always a default exponential fallback config (unless otherwise specified) when making requests.