tests: ls: verify LC_COLLATE is honored when sorting filenames#269
Open
sylvestre wants to merge 1 commit into
Open
tests: ls: verify LC_COLLATE is honored when sorting filenames#269sylvestre wants to merge 1 commit into
sylvestre wants to merge 1 commit into
Conversation
* tests/ls/sort-collation.sh: new test covering three locale scenarios (C, full UTF-8 locale via LC_ALL, and LC_COLLATE alone with LC_ALL unset). * tests/local.mk (all_tests): Add it. This guards against regressions where ls sorts as if LC_COLLATE=C regardless of the locale category, as reported for uutils: uutils/coreutils#12474
Member
|
Thanks, but this patch feels a bit more simple to me. WDYT @pixelb? |
Contributor
Author
|
@collinfunk sounds good :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This guards against regressions where ls sorts as if LC_COLLATE=C regardless of the locale category, as reported for uutils: uutils/coreutils#12474