Skip to content

Restore the default meaning of --pull (should be always).#6300

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Romain-Geissler-1A:restore-pull-default-meaning
Jul 28, 2025
Merged

Restore the default meaning of --pull (should be always).#6300
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Romain-Geissler-1A:restore-pull-default-meaning

Conversation

@Romain-Geissler-1A
Copy link
Contributor

@Romain-Geissler-1A Romain-Geissler-1A commented Jul 25, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Now the bud --help output reads this, correctly showing both "missing" and "always" defaults, if --pull is explicitly provided or not:

      --pull string[="always"]                       pull base and SBOM scanner images from the registry. Values:
                                                     always:  pull base and SBOM scanner images even if the named images are present in store.
                                                     missing: pull base and SBOM scanner images if the named images are not present in store.
                                                     newer:   only pull base and SBOM scanner images when newer images exist on the registry than those in the store. (default "missing")

How to verify it

Which issue(s) this PR fixes:

Fixes #6266.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Restore the meaning of `--pull` (without argument), similar to the docker behavior: now defaults to `--pull=always`

@Romain-Geissler-1A Romain-Geissler-1A force-pushed the restore-pull-default-meaning branch from 4f00a58 to b30da40 Compare July 25, 2025 19:47
@packit-as-a-service
Copy link

packit-as-a-service bot commented Jul 25, 2025

Ephemeral COPR build failed. @containers/packit-build please check.

@Romain-Geissler-1A Romain-Geissler-1A force-pushed the restore-pull-default-meaning branch from b30da40 to d2d4e09 Compare July 25, 2025 19:48
@Romain-Geissler-1A Romain-Geissler-1A changed the title Restore the default meaning of --pull (should be "always). Restore the default meaning of --pull (should be always). Jul 25, 2025
@Romain-Geissler-1A Romain-Geissler-1A force-pushed the restore-pull-default-meaning branch 3 times, most recently from 507a39c to cc95bc7 Compare July 26, 2025 09:46
Luap99
Luap99 approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, chnage itself LGTM. Can you reformat your commit message to not include the full --help output with all the extra spaces. That makes it harder to view the commit message.

@nalind @flouthoc @TomSweeneyRedHat PTAL

flouthoc
flouthoc approved these changes Jul 28, 2025
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Romain-Geissler-1A Romain-Geissler-1A force-pushed the restore-pull-default-meaning branch from cc95bc7 to 49f8854 Compare July 28, 2025 16:21
@Romain-Geissler-1A
Restore the default meaning of --pull (should be always).
f949a49 
Now the bud --help output correctly reads that the default behavior when
--pull is not provided at all is "missing", and that the default value
for --pull if explicitly provided but without value is "always".

Fixes containers#6266.

Signed-off-by: Romain Geissler <[email protected]>
@Romain-Geissler-1A Romain-Geissler-1A force-pushed the restore-pull-default-meaning branch from 49f8854 to f949a49 Compare July 28, 2025 16:21
@Romain-Geissler-1A
Copy link
Contributor Author

Romain-Geissler-1A commented Jul 28, 2025

Can you reformat your commit message to not include the full --help output with all the extra spaces. That makes it harder to view the commit message.

Done, please check if the updated commit message is fine.

@Romain-Geissler-1A
Copy link
Contributor Author

Romain-Geissler-1A commented Jul 28, 2025

In term of release cycle, how late are we to get this included in podman 5.6 ? Or, in my case, in the next RHEL podman (which I guess will be based on podman 5.6) ? We are using both RHEL 9 & 10 at the moment.

giuseppe
giuseppe approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Luap99
Luap99 approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, Luap99, Romain-Geissler-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Luap99,flouthoc,giuseppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member

Luap99 commented Jul 28, 2025

In term of release cycle, how late are we to get this included in podman 5.6 ? Or, in my case, in the next RHEL podman (which I guess will be based on podman 5.6) ? We are using both RHEL 9 & 10 at the moment.

Well 1.41.0 is what will be in podman 5.6 so by that definition it is to late already.
However IMO this is a regressions and as such a bug fix so I see nor problem for us to cut a 1.41.1 with this fix and then vendor that into podman 5.6. The final podman 5.6 release is in two weeks so we still have some time for that.

cc @TomSweeneyRedHat @nalind

@nalind
Copy link
Member

nalind commented Jul 28, 2025

I'd like to see this in a 1.41.1.
Thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 88e7e23 into containers:main Jul 28, 2025
37 checks passed
@nalind
Copy link
Member

nalind commented Jul 30, 2025

/cherry-pick release-1.41

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 30, 2025

@nalind: new pull request created: #6305

Details

In response to this:

/cherry-pick release-1.41

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 30, 2025
Merged
@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Aug 7, 2025

Ooops, missed this until now. @nalind TYVM for dropping this into 1.41.1

@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@giuseppe giuseppe giuseppe approved these changes

@flouthoc flouthoc flouthoc approved these changes

@Luap99 Luap99 Luap99 approved these changes

Assignees

@nalind nalind

Labels

approved lgtm locked - please file new issue/PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Podman >= 5.2 changed the meaning of --pull (without argument)

7 participants

@Romain-Geissler-1A @Luap99 @nalind @openshift-cherrypick-robot @TomSweeneyRedHat @giuseppe @flouthoc