Skip to content

commit-with-extra-files test: use $TEST_SCRATCH_DIR#6231

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
nalind:bats-tmpdir
Jun 18, 2025
Merged

commit-with-extra-files test: use $TEST_SCRATCH_DIR#6231
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
nalind:bats-tmpdir

Conversation

@nalind
Copy link
Member

@nalind nalind commented Jun 17, 2025

What type of PR is this?

/kind other

What this PR does / why we need it:

Use $TEST_SCRATCH_DIR instead of $BATS_TMPDIR for temporary files that we create during one of our integration tests.

How to verify it

The test shouldn't be broken by this change.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Use $TEST_SCRATCH_DIR instead of $BATS_TMPDIR for temporary files that
we create during this test.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@TomSweeneyRedHat
Copy link
Member

LGTM
assuming happy tests

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d944211 into containers:main Jun 18, 2025
37 checks passed
@nalind nalind deleted the bats-tmpdir branch June 18, 2025 11:47
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants